You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/11/23 19:32:20 UTC

Review Request 40604: Yarn hadoop.registry.rm.enabled value should be fetched from stack adviser

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40604/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.


Bugs: AMBARI-14024
    https://issues.apache.org/jira/browse/AMBARI-14024


Repository: ambari


Description
-------

hadoop.registry.rm.enabled value is changing on UI depending if SLIDER service is selected.
This value is changing without any notification for user which is not good, moving this property to adviser will allow to display this change in recommendation popup.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 7201de8 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 0acaaff 

Diff: https://reviews.apache.org/r/40604/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 40604: Yarn hadoop.registry.rm.enabled value should be fetched from stack adviser

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40604/#review107731
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Nov. 23, 2015, 8:32 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40604/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 8:32 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-14024
>     https://issues.apache.org/jira/browse/AMBARI-14024
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> hadoop.registry.rm.enabled value is changing on UI depending if SLIDER service is selected.
> This value is changing without any notification for user which is not good, moving this property to adviser will allow to display this change in recommendation popup.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 7201de8 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 0acaaff 
> 
> Diff: https://reviews.apache.org/r/40604/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>