You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/24 20:07:27 UTC

[GitHub] [spark] gengliangwang commented on pull request #37649: [SPARK-40209][SQL] Don't change the interval value of Decimal in `changePrecision()` on errors

gengliangwang commented on PR #37649:
URL: https://github.com/apache/spark/pull/37649#issuecomment-1226225115

   Spark's decimal has two methods by design:
   * changePrecision: update in place for better performance
   * toPrecision: make a copy and check if changing precision works
   
   This change seems to break the design. Also, as mentioned in https://github.com/apache/spark/pull/37620#discussion_r954096295, I think it is better to show the original value string representation in the error


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org