You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@camel.apache.org by GitBox <gi...@apache.org> on 2019/05/28 11:14:46 UTC

[GitHub] [camel-k] jamesnetherton opened a new pull request #696: feat: Set env var with Kamel

jamesnetherton opened a new pull request #696: feat: Set env var with Kamel
URL: https://github.com/apache/camel-k/pull/696
 
 
   fixes #606
   
   In terms of the potential for users to break things with this feature, I think we've ended up with an ok compromise.
   
   Since the configuration of environment variables from traits etc, comes after those provided from 'kamel run', it results in those values taking precedence over the user provided ones. I think that's acceptable in the majority of cases.
   
   E.g. If someone did `kamel run simple.js -e JAVA_MAIN_CLASS=some.invalid.Thing`, then `JAVA_MAIN_CLASS` would get ignored and restored to the camel-k default.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services