You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "pegasas (via GitHub)" <gi...@apache.org> on 2023/08/04 05:56:52 UTC
[GitHub] [flink] pegasas opened a new pull request, #23135: [FLINK-32741]Remove DataSet related descriptions in doc
pegasas opened a new pull request, #23135:
URL: https://github.com/apache/flink/pull/23135
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #23135: [FLINK-32741]Remove DataSet related descriptions in doc
Posted by "xintongsong (via GitHub)" <gi...@apache.org>.
xintongsong commented on PR #23135:
URL: https://github.com/apache/flink/pull/23135#issuecomment-1665254926
Thanks, @pegasas.
I think https://github.com/apache/flink/blob/master/docs/content.zh/docs/dev/dataset/hadoop_compatibility.md should be removed. Actually, this file only exist for the `content.zh` but not for `content`. If you check the git history, you'll find that hadoop format related documents have been moved to `connectors/datastream/formats` in FLINK-21407, where the Chinese translation was overlooked.
I'll review the other changes asap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pegasas commented on pull request #23135: [FLINK-32741]Remove DataSet related descriptions in doc
Posted by "pegasas (via GitHub)" <gi...@apache.org>.
pegasas commented on PR #23135:
URL: https://github.com/apache/flink/pull/23135#issuecomment-1665086019
Hi, @xintongsong, @WencongLiu ,
I deprecated all files on /dev/dataset on content/ and content.zh
in my private view, all dataset sub-document should be deprecated now.
https://github.com/apache/flink/blob/master/docs/content.zh/docs/dev/dataset/hadoop_compatibility.md for this I am not definitely sure about that, but in my user experience, It seems we have FLIP-27/143 FileSource/FileSink which could directly write to local/distributed file system? not sure if it is outdated.
And I correct several files as a result and I search 'Dataset' as a keyword. I correct them with my limited understanding and user experience.
feel free to correct me if there is any concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #23135: [FLINK-32741]Remove DataSet related descriptions in doc
Posted by "xintongsong (via GitHub)" <gi...@apache.org>.
xintongsong closed pull request #23135: [FLINK-32741]Remove DataSet related descriptions in doc
URL: https://github.com/apache/flink/pull/23135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on a diff in pull request #23135: [FLINK-32741]Remove DataSet related descriptions in doc
Posted by "xintongsong (via GitHub)" <gi...@apache.org>.
xintongsong commented on code in PR #23135:
URL: https://github.com/apache/flink/pull/23135#discussion_r1285183171
##########
docs/content/docs/dev/datastream/scala_api_extensions.md:
##########
@@ -198,14 +198,8 @@ To use this extension exclusively, you can add the following `import`:
import org.apache.flink.api.scala.extensions.acceptPartialFunctions
{{< /highlight >}}
-for the DataSet extensions and
-
-{{< highlight scala >}}
-import org.apache.flink.streaming.api.scala.extensions.acceptPartialFunctions
-{{< /highlight >}}
-
The following snippet shows a minimal example of how to use these extension
-methods together (with the DataSet API):
Review Comment:
It's probably out of the scope of this PR. I wonder if we should simply also remove all Scala API documentations.
##########
docs/content/docs/concepts/stateful-stream-processing.md:
##########
@@ -342,26 +342,3 @@ give *exactly once* guarantees even in *at least once* mode.
{{< /hint >}}
{{< top >}}
-
-## State and Fault Tolerance in Batch Programs
-
-Flink executes [batch programs]({{< ref "docs/dev/dataset/overview" >}}) as a special case of
-streaming programs, where the streams are bounded (finite number of elements).
-A *DataSet* is treated internally as a stream of data. The concepts above thus
-apply to batch programs in the same way as well as they apply to streaming
-programs, with minor exceptions:
-
- - [Fault tolerance for batch programs]({{< ref "docs/ops/state/task_failure_recovery" >}})
- does not use checkpointing. Recovery happens by fully replaying the
- streams. That is possible, because inputs are bounded. This pushes the
- cost more towards the recovery, but makes the regular processing cheaper,
- because it avoids checkpoints.
-
- - Stateful operations in the DataSet API use simplified in-memory/out-of-core
- data structures, rather than key/value indexes.
-
- - The DataSet API introduces special synchronized (superstep-based)
- iterations, which are only possible on bounded streams. For details, check
- out the [iteration docs]({{< ref "docs/dev/dataset/iterations" >}}).
Review Comment:
I don't think these should all be removed. These contents also applies to DataStream jobs in batch execution mode.
I'd suggest:
1. Link `batch programs` to DataStream Batch Execution mode: `docs/dev/datastream/execution_mode`
2. Remove "A *DataSet* is treated internally as a stream of data."
3. Change "Stateful operations in the DataSet API" to "State backend in batch execution mode".
4. Remove "The DataSet API introduces special synchronized (superstep-based) iterations, which are only possible on bounded streams. For details, check out the [iteration docs]({{< ref "docs/dev/dataset/iterations" >}}).".
##########
docs/content/docs/ops/state/task_failure_recovery.md:
##########
@@ -334,7 +334,7 @@ A region is a set of tasks that communicate via pipelined data exchanges.
That is, batch data exchanges denote the boundaries of a region.
- All data exchanges in a DataStream job or Streaming Table/SQL job are pipelined.
- All data exchanges in a Batch Table/SQL job are batched by default.
-- The data exchange types in a DataSet job are determined by the
+- The data exchange types in a DataStream job are determined by the
Review Comment:
I think this page is outdated. Currently, all DataStream / Table / SQL jobs should rely on `ExecutionMode` for determining the data exchange type. We probably can combine these 3 items into 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pegasas commented on pull request #23135: [FLINK-32741]Remove DataSet related descriptions in doc
Posted by "pegasas (via GitHub)" <gi...@apache.org>.
pegasas commented on PR #23135:
URL: https://github.com/apache/flink/pull/23135#issuecomment-1668891282
> @pegasas, thanks for addressing the comments. LGTM. Merging.
Thanks @xintongsong for reviewing and suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #23135: [FLINK-32741]Remove DataSet related descriptions in doc
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23135:
URL: https://github.com/apache/flink/pull/23135#issuecomment-1665062098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08e4c5c5f26e7c5f51341a8732f1458841e3154c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "08e4c5c5f26e7c5f51341a8732f1458841e3154c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08e4c5c5f26e7c5f51341a8732f1458841e3154c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pegasas commented on a diff in pull request #23135: [FLINK-32741]Remove DataSet related descriptions in doc
Posted by "pegasas (via GitHub)" <gi...@apache.org>.
pegasas commented on code in PR #23135:
URL: https://github.com/apache/flink/pull/23135#discussion_r1285223853
##########
docs/content/docs/concepts/stateful-stream-processing.md:
##########
@@ -342,26 +342,3 @@ give *exactly once* guarantees even in *at least once* mode.
{{< /hint >}}
{{< top >}}
-
-## State and Fault Tolerance in Batch Programs
-
-Flink executes [batch programs]({{< ref "docs/dev/dataset/overview" >}}) as a special case of
-streaming programs, where the streams are bounded (finite number of elements).
-A *DataSet* is treated internally as a stream of data. The concepts above thus
-apply to batch programs in the same way as well as they apply to streaming
-programs, with minor exceptions:
-
- - [Fault tolerance for batch programs]({{< ref "docs/ops/state/task_failure_recovery" >}})
- does not use checkpointing. Recovery happens by fully replaying the
- streams. That is possible, because inputs are bounded. This pushes the
- cost more towards the recovery, but makes the regular processing cheaper,
- because it avoids checkpoints.
-
- - Stateful operations in the DataSet API use simplified in-memory/out-of-core
- data structures, rather than key/value indexes.
-
- - The DataSet API introduces special synchronized (superstep-based)
- iterations, which are only possible on bounded streams. For details, check
- out the [iteration docs]({{< ref "docs/dev/dataset/iterations" >}}).
Review Comment:
sure.
This is a good point.
I will search the others to see if any other same pattern, which could be executed in BATCH mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pegasas commented on a diff in pull request #23135: [FLINK-32741]Remove DataSet related descriptions in doc
Posted by "pegasas (via GitHub)" <gi...@apache.org>.
pegasas commented on code in PR #23135:
URL: https://github.com/apache/flink/pull/23135#discussion_r1285386467
##########
docs/content/docs/dev/datastream/scala_api_extensions.md:
##########
@@ -198,14 +198,8 @@ To use this extension exclusively, you can add the following `import`:
import org.apache.flink.api.scala.extensions.acceptPartialFunctions
{{< /highlight >}}
-for the DataSet extensions and
-
-{{< highlight scala >}}
-import org.apache.flink.streaming.api.scala.extensions.acceptPartialFunctions
-{{< /highlight >}}
-
The following snippet shows a minimal example of how to use these extension
-methods together (with the DataSet API):
Review Comment:
Sure. I saw there is another work item [[FLIP-265] Remove all Scala APIs](https://issues.apache.org/jira/browse/FLINK-29741) in 2.0 burndown, maybe we can track in that thread.
##########
docs/content/docs/ops/state/task_failure_recovery.md:
##########
@@ -334,7 +334,7 @@ A region is a set of tasks that communicate via pipelined data exchanges.
That is, batch data exchanges denote the boundaries of a region.
- All data exchanges in a DataStream job or Streaming Table/SQL job are pipelined.
- All data exchanges in a Batch Table/SQL job are batched by default.
-- The data exchange types in a DataSet job are determined by the
+- The data exchange types in a DataStream job are determined by the
Review Comment:
Sure. Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org