[jira] [Work logged] (ARTEMIS-2582) EmbeddedActiveMQ.stop() should check for null

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-2582?focusedWorklogId=690204&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690204 ]

ASF GitHub Bot logged work on ARTEMIS-2582:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Dec/21 17:31
            Start Date: 03/Dec/21 17:31
    Worklog Time Spent: 10m 
      Work Description: gtully commented on pull request #3811:
URL: https://github.com/apache/activemq-artemis/pull/3811#issuecomment-985701369


   it may as well have a little test, to ensure there is no regression in the future


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 690204)
    Time Spent: 2h 50m  (was: 2h 40m)

> EmbeddedActiveMQ.stop() should check for null
> ---------------------------------------------
>
>                 Key: ARTEMIS-2582
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2582
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.10.1
>            Reporter: SL
>            Priority: Trivial
>              Labels: easy
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/embedded/EmbeddedActiveMQ.java
> when calling {{EmbeddedActiveMQ.stop()}} method, there is no guarantee that the init was called or successful (responsability of the caller)
> the method should check that activeMQServer is not null
> {code:java}
>    public EmbeddedActiveMQ stop() throws Exception {
> +      if (activeMQServer != null) {
>            activeMQServer.stop();
> +      }
>       return this;
>    }
> {code}
> use case : after methods in unit tests.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)