Re: Review Request 23985: CLOUDSTACK-7193: handle domain ID being an int

[Sebastien Goasguen <ru...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23985/#review50964
-----------------------------------------------------------

Ship it!


thanks applied to master, 4.3 and 4.4 for 4.4.1 release
please mark the review as submitted
thanks for the patch, keep them coming.

- Sebastien Goasguen


On July 28, 2014, 4:07 p.m., Vincent Bernat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23985/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 4:07 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-7193: handle domain ID being an int
> 
> Recent versions of libvirt (at least 0.9.8) will return an int when
> queried for the ID of a domain, not a string. This breaks some parts of
> the `security_group.py` script which expects a string containing an
> int. Notably, this breaks the part handling VM reboots which is
> therefore not executed.
> 
> 
> Diffs
> -----
> 
>   scripts/vm/network/security_group.py 704b27982021 
> 
> Diff: https://reviews.apache.org/r/23985/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vincent Bernat
> 
>