You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/18 16:59:09 UTC
[GitHub] [kafka] mumrah opened a new pull request #10149: AbstractCoordinator should log with its subclass
mumrah opened a new pull request #10149:
URL: https://github.com/apache/kafka/pull/10149
While debugging some group coordinator issues I noticed the consumer coordinator was logging using `org.apache.kafka.clients.consumer.internals.AbstractCoordinator` as the logger. Since there are two implementations of AbstractCoordinator, we should probably use the subclass as the logger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mumrah commented on pull request #10149: AbstractCoordinator should log with its subclass
Posted by GitBox <gi...@apache.org>.
mumrah commented on pull request #10149:
URL: https://github.com/apache/kafka/pull/10149#issuecomment-782182562
@chia7712 are you referring to L161 in AbstractCoordinator? Or are you suggesting we apply this change more broadly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #10149: AbstractCoordinator should log with its subclass
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #10149:
URL: https://github.com/apache/kafka/pull/10149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #10149: AbstractCoordinator should log with its subclass
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10149:
URL: https://github.com/apache/kafka/pull/10149#issuecomment-782314292
> Or are you suggesting we apply this change more broadly?
Yep, I feel this change can be applied more broadly :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org