[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3354: ARTEMIS-3005 Fix scaling down AMQP messages routing

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #3354:
URL: https://github.com/apache/activemq-artemis/pull/3354#discussion_r527856927



##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ScaleDownTest.java
##########
@@ -379,27 +393,107 @@ public void testScaleDownWithMissingQueue() throws Exception {
    public void testScaleDownWithMissingAnycastQueue() throws Exception {
       final int TEST_SIZE = 2;
       final String addressName = "testAddress";
-      final String queueName1 = "testQueue1";
-      final String queueName2 = "testQueue2";
+      final String queueName = "testQueue";
 
       // create 2 queues on each node mapped to the same address
-      createQueue(0, addressName, queueName2, null, false, null, null, RoutingType.ANYCAST);
+      createQueue(0, addressName, queueName, null, false, null, null, RoutingType.ANYCAST);

Review comment:
       What happened to queue2 this is semantically changing the test case




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org