You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/03 16:09:04 UTC

[jira] [Commented] (IGNITE-5097) BinaryMarshaller should write ints in "varint" encoding where it makes sense

    [ https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995144#comment-15995144 ] 

ASF GitHub Bot commented on IGNITE-5097:
----------------------------------------

GitHub user daradurvs opened a pull request:

    https://github.com/apache/ignite/pull/1902

    IGNITE-5097

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daradurvs/ignite ignite-5097

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1902.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1902
    
----
commit 8156af3f7c9d2e05bda0dd19522af1418987886a
Author: Vyacheslav Daradur <da...@gmail.com>
Date:   2017-04-28T11:11:29Z

    ignite-5097: wip

commit 49f9019abfc495fc5ffaf8fe53302e8de735489e
Author: Vyacheslav Daradur <da...@gmail.com>
Date:   2017-04-28T13:47:10Z

    ignite-5097: writing string with varint was implemented

commit 9907d647dce33413bd1e3cedeb1efa6bdf4b8dd9
Author: Vyacheslav Daradur <da...@gmail.com>
Date:   2017-04-28T13:55:10Z

    ignite-5097: writing enum ordinals in varint was implemented

commit 6a7349a50e173ac964ac60e2b89da272c213c293
Author: Vyacheslav Daradur <da...@gmail.com>
Date:   2017-04-28T14:23:32Z

    ignite-5097: writing of decimal scale and bytes array length in varint format was implemented

commit c3ee1e2d54ba428a5acd7007ca309089849a877d
Author: Vyacheslav Daradur <da...@gmail.com>
Date:   2017-05-02T14:44:46Z

    ignite-5097: writing array/collection/map lengths in varint encoding was implemented

commit fba5e97ed7515718d2d87573b0059d14ea61d01e
Author: Vyacheslav Daradur <da...@gmail.com>
Date:   2017-05-03T08:30:24Z

    ignite-5097: refactoring

commit 6166519ed06a1d30da15046792e93a15f9bde528
Author: Vyacheslav Daradur <da...@gmail.com>
Date:   2017-05-03T11:51:04Z

    ignite-5097: refactoring; tests for sizeof-methods were added

commit d75dda28559926db1422b2c2f28c6b8d32290c01
Author: Vyacheslav Daradur <da...@gmail.com>
Date:   2017-05-03T12:29:53Z

    ignite-5097: fixes

commit 9707585a3c2b82fb03e460eee6a49b0c920acc93
Author: Vyacheslav Daradur <da...@gmail.com>
Date:   2017-05-03T15:38:24Z

    ignite-5097: fixes part 2

----


> BinaryMarshaller should write ints in "varint" encoding where it makes sense
> ----------------------------------------------------------------------------
>
>                 Key: IGNITE-5097
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5097
>             Project: Ignite
>          Issue Type: Task
>          Components: general
>    Affects Versions: 2.0
>            Reporter: Vladimir Ozerov
>            Assignee: Vyacheslav Daradur
>              Labels: important, performance
>             Fix For: 2.1
>
>
> There are a lot of places in the code where we write integers for some special purposes. Quite often their value will be vary small, so that applying "varint" format could save a lot of space at the cost of very low additional CPU overhead. 
> Specifically:
> 1) Array/collection/map lengths
> 2) BigDecimal's (usually will save ~6 bytes)
> 3) Strings
> 4) Enum ordinals



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)