You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/05 18:04:12 UTC
[jira] [Commented] (STORM-1730) LocalCluster#shutdown() does not
terminate all storm threads/thread pools.
[ https://issues.apache.org/jira/browse/STORM-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272736#comment-15272736 ]
ASF GitHub Bot commented on STORM-1730:
---------------------------------------
GitHub user fbyrne opened a pull request:
https://github.com/apache/storm/pull/1400
STORM-1730 LocalCluster#shutdown() does not terminate all storm threads/thread pools.
The thread pool executor used by the `DisruptorQueue.FlusherPool` is in a static context of the
DisruptorQueue. To avoid major changes to how this queues lifecycle is
managed I added a simple fix is to create a thread pool factory which creates daemon
threads. The threads are now also named with the 'disruptor-flush'
prefix to be consistent with the TimerTask.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fbyrne/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1400.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1400
----
commit 3c78314e18e21cd188cd7b8e5ae3f2143ed75cbd
Author: Fergus Byrne <fe...@gmail.com>
Date: 2016-05-05T16:32:33Z
STORM-1730 LocalCluster#shutdown() does not terminate all storm
threads/thread pools.
The thread pool that is remaining is in a static context of the
DisruptorQueue. To avoid major changes to how this queues lifecycle is
managed the fix is to create a thread pool factory which creates daemon
threads. The threads are now also named with the 'disruptor-flush'
prefix to be consistent with the TimerTask.
----
> LocalCluster#shutdown() does not terminate all storm threads/thread pools.
> --------------------------------------------------------------------------
>
> Key: STORM-1730
> URL: https://issues.apache.org/jira/browse/STORM-1730
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.0
> Environment: Windows 7 x64
> Oracle Java 1.8.0 u92 x64
> Reporter: Fergus Byrne
> Priority: Minor
> Attachments: Thread Pool '47' remaining..png, storm-shutdown-issue.zip
>
>
> When using the LocalCluster in test setup. LocalCluster#shutdown() does not shutdown all executor services it starts. In my test case, there is a single thread pool executor service that is not shutdown and not daemon. This keeps the jvm alive when it is expected to terminate.
> Please see attached test case. In my example, thread pool 47 is not shutdown. Naming here is conditional on threading.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)