You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by ca...@apache.org on 2021/10/06 04:17:05 UTC
[samza] branch master updated: SAMZA-2679: Add missing Override
annotations (#1539)
This is an automated email from the ASF dual-hosted git repository.
cameronlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/samza.git
The following commit(s) were added to refs/heads/master by this push:
new bc9e93f SAMZA-2679: Add missing Override annotations (#1539)
bc9e93f is described below
commit bc9e93f1e9043136c9b6e073a7f3468d527394db
Author: Jon Bringhurst <jo...@bringhurst.org>
AuthorDate: Tue Oct 5 21:16:11 2021 -0700
SAMZA-2679: Add missing Override annotations (#1539)
---
.../src/main/java/org/apache/samza/checkpoint/CheckpointV1.java | 1 +
.../src/main/java/org/apache/samza/checkpoint/CheckpointV2.java | 1 +
samza-api/src/main/java/org/apache/samza/config/Config.java | 5 +++++
samza-api/src/main/java/org/apache/samza/config/MapConfig.java | 8 ++++++++
samza-api/src/main/java/org/apache/samza/job/model/TaskMode.java | 1 +
samza-api/src/main/java/org/apache/samza/job/model/TaskModel.java | 1 +
samza-api/src/main/java/org/apache/samza/metrics/Counter.java | 2 ++
samza-api/src/main/java/org/apache/samza/metrics/Gauge.java | 2 ++
.../src/main/java/org/apache/samza/metrics/SamzaHistogram.java | 2 ++
.../java/org/apache/samza/metrics/SlidingTimeWindowReservoir.java | 2 ++
.../main/java/org/apache/samza/serializers/ByteBufferSerde.java | 2 ++
.../java/org/apache/samza/serializers/ByteBufferSerdeFactory.java | 1 +
.../src/main/java/org/apache/samza/serializers/ByteSerde.java | 2 ++
.../main/java/org/apache/samza/serializers/ByteSerdeFactory.java | 1 +
.../src/main/java/org/apache/samza/serializers/DoubleSerde.java | 2 ++
.../java/org/apache/samza/serializers/DoubleSerdeFactory.java | 1 +
.../src/main/java/org/apache/samza/serializers/IntegerSerde.java | 2 ++
.../java/org/apache/samza/serializers/IntegerSerdeFactory.java | 1 +
.../src/main/java/org/apache/samza/serializers/JsonSerdeV2.java | 2 ++
.../java/org/apache/samza/serializers/JsonSerdeV2Factory.java | 1 +
samza-api/src/main/java/org/apache/samza/serializers/KVSerde.java | 2 ++
.../src/main/java/org/apache/samza/serializers/LongSerde.java | 2 ++
.../main/java/org/apache/samza/serializers/LongSerdeFactory.java | 1 +
.../src/main/java/org/apache/samza/serializers/NoOpSerde.java | 2 ++
.../main/java/org/apache/samza/serializers/SerializableSerde.java | 2 ++
.../org/apache/samza/serializers/SerializableSerdeFactory.java | 1 +
.../src/main/java/org/apache/samza/serializers/StringSerde.java | 2 ++
.../java/org/apache/samza/serializers/StringSerdeFactory.java | 1 +
.../src/main/java/org/apache/samza/serializers/UUIDSerde.java | 2 ++
.../main/java/org/apache/samza/serializers/UUIDSerdeFactory.java | 1 +
.../src/main/java/org/apache/samza/system/BoundedSSPIterator.java | 2 ++
.../java/org/apache/samza/system/chooser/BaseMessageChooser.java | 3 +++
.../src/main/java/org/apache/samza/util/BlockingEnvelopeMap.java | 1 +
33 files changed, 62 insertions(+)
diff --git a/samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointV1.java b/samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointV1.java
index 3e2cce3..93972e4 100644
--- a/samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointV1.java
+++ b/samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointV1.java
@@ -44,6 +44,7 @@ public class CheckpointV1 implements Checkpoint {
this.offsets = offsets;
}
+ @Override
public short getVersion() {
return CHECKPOINT_VERSION;
}
diff --git a/samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointV2.java b/samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointV2.java
index ac553f4..9f5cef5 100644
--- a/samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointV2.java
+++ b/samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointV2.java
@@ -59,6 +59,7 @@ public class CheckpointV2 implements Checkpoint {
this.stateCheckpointMarkers = ImmutableMap.copyOf(stateCheckpoints);
}
+ @Override
public short getVersion() {
return CHECKPOINT_VERSION;
}
diff --git a/samza-api/src/main/java/org/apache/samza/config/Config.java b/samza-api/src/main/java/org/apache/samza/config/Config.java
index 2b0d2ed..d10e174 100644
--- a/samza-api/src/main/java/org/apache/samza/config/Config.java
+++ b/samza-api/src/main/java/org/apache/samza/config/Config.java
@@ -231,22 +231,27 @@ public abstract class Config implements Map<String, String>, Serializable {
public abstract Config sanitize();
+ @Override
public void clear() {
throw new ConfigException("Config is immutable.");
}
+ @Override
public String put(String key, String value) {
throw new ConfigException("Config is immutable.");
}
+ @Override
public void putAll(Map<? extends String, ? extends String> m) {
throw new ConfigException("Config is immutable.");
}
+ @Override
public String remove(Object s) {
throw new ConfigException("Config is immutable.");
}
+ @Override
public void replaceAll(BiFunction<? super String, ? super String, ? extends String> function) {
throw new ConfigException("Config is immutable.");
}
diff --git a/samza-api/src/main/java/org/apache/samza/config/MapConfig.java b/samza-api/src/main/java/org/apache/samza/config/MapConfig.java
index 213d453..490bf5b 100644
--- a/samza-api/src/main/java/org/apache/samza/config/MapConfig.java
+++ b/samza-api/src/main/java/org/apache/samza/config/MapConfig.java
@@ -55,34 +55,42 @@ public class MapConfig extends Config {
this(Arrays.asList(maps));
}
+ @Override
public String get(Object k) {
return map.get(k);
}
+ @Override
public boolean containsKey(Object k) {
return map.containsKey(k);
}
+ @Override
public Set<Map.Entry<String, String>> entrySet() {
return map.entrySet();
}
+ @Override
public boolean isEmpty() {
return map.isEmpty();
}
+ @Override
public Set<String> keySet() {
return map.keySet();
}
+ @Override
public int size() {
return map.size();
}
+ @Override
public Collection<String> values() {
return map.values();
}
+ @Override
public boolean containsValue(Object v) {
return map.containsValue(v);
}
diff --git a/samza-api/src/main/java/org/apache/samza/job/model/TaskMode.java b/samza-api/src/main/java/org/apache/samza/job/model/TaskMode.java
index c98b94d..e27ec50 100644
--- a/samza-api/src/main/java/org/apache/samza/job/model/TaskMode.java
+++ b/samza-api/src/main/java/org/apache/samza/job/model/TaskMode.java
@@ -32,6 +32,7 @@ public enum TaskMode {
this.mode = mode;
}
+ @Override
public String toString() {
return this.mode;
}
diff --git a/samza-api/src/main/java/org/apache/samza/job/model/TaskModel.java b/samza-api/src/main/java/org/apache/samza/job/model/TaskModel.java
index c29a714..e224e04 100644
--- a/samza-api/src/main/java/org/apache/samza/job/model/TaskModel.java
+++ b/samza-api/src/main/java/org/apache/samza/job/model/TaskModel.java
@@ -133,6 +133,7 @@ public class TaskModel implements Comparable<TaskModel> {
+ ", changeLogPartition=" + changelogPartition + ", taskMode=" + this.taskMode + "]";
}
+ @Override
public int compareTo(TaskModel other) {
return taskName.compareTo(other.getTaskName());
}
diff --git a/samza-api/src/main/java/org/apache/samza/metrics/Counter.java b/samza-api/src/main/java/org/apache/samza/metrics/Counter.java
index 6a85c66..a338c34 100644
--- a/samza-api/src/main/java/org/apache/samza/metrics/Counter.java
+++ b/samza-api/src/main/java/org/apache/samza/metrics/Counter.java
@@ -66,10 +66,12 @@ public class Counter implements Metric {
return name;
}
+ @Override
public void visit(MetricsVisitor visitor) {
visitor.counter(this);
}
+ @Override
public String toString() {
return count.toString();
}
diff --git a/samza-api/src/main/java/org/apache/samza/metrics/Gauge.java b/samza-api/src/main/java/org/apache/samza/metrics/Gauge.java
index be1f01d..cf3b5d0 100644
--- a/samza-api/src/main/java/org/apache/samza/metrics/Gauge.java
+++ b/samza-api/src/main/java/org/apache/samza/metrics/Gauge.java
@@ -53,10 +53,12 @@ public class Gauge<T> implements Metric {
return name;
}
+ @Override
public void visit(MetricsVisitor visitor) {
visitor.gauge(this);
}
+ @Override
public String toString() {
T value = ref.get();
return (value == null) ? null : value.toString();
diff --git a/samza-api/src/main/java/org/apache/samza/metrics/SamzaHistogram.java b/samza-api/src/main/java/org/apache/samza/metrics/SamzaHistogram.java
index bdbe403..2cef145 100644
--- a/samza-api/src/main/java/org/apache/samza/metrics/SamzaHistogram.java
+++ b/samza-api/src/main/java/org/apache/samza/metrics/SamzaHistogram.java
@@ -71,6 +71,7 @@ public class SamzaHistogram {
this.percentile = percentile;
}
+ @Override
public void visit(MetricsVisitor visitor) {
visitor.gauge(this);
}
@@ -80,6 +81,7 @@ public class SamzaHistogram {
* This is needed for reporters which do not implement MetricsReporter
* and do not have MetricsReporter to update the values.
*/
+ @Override
public Double getValue() {
/*
* We cannot updateGaugeValues if the histogram gauges are being instantiated
diff --git a/samza-api/src/main/java/org/apache/samza/metrics/SlidingTimeWindowReservoir.java b/samza-api/src/main/java/org/apache/samza/metrics/SlidingTimeWindowReservoir.java
index 4116473..5a29c43 100644
--- a/samza-api/src/main/java/org/apache/samza/metrics/SlidingTimeWindowReservoir.java
+++ b/samza-api/src/main/java/org/apache/samza/metrics/SlidingTimeWindowReservoir.java
@@ -78,6 +78,7 @@ public class SlidingTimeWindowReservoir implements Reservoir {
*/
public SlidingTimeWindowReservoir() {
this(DEFAULT_WINDOW_SIZE_MS, new Clock() {
+ @Override
public long currentTimeMillis() {
return System.currentTimeMillis();
}
@@ -91,6 +92,7 @@ public class SlidingTimeWindowReservoir implements Reservoir {
*/
public SlidingTimeWindowReservoir(long windowMs) {
this(windowMs, new Clock() {
+ @Override
public long currentTimeMillis() {
return System.currentTimeMillis();
}
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/ByteBufferSerde.java b/samza-api/src/main/java/org/apache/samza/serializers/ByteBufferSerde.java
index c2ea594..36ce696 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/ByteBufferSerde.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/ByteBufferSerde.java
@@ -26,6 +26,7 @@ import java.nio.ByteBuffer;
*/
public class ByteBufferSerde implements Serde<ByteBuffer> {
+ @Override
public byte[] toBytes(ByteBuffer byteBuffer) {
if (byteBuffer != null) {
byte[] bytes = new byte[byteBuffer.remaining()];
@@ -36,6 +37,7 @@ public class ByteBufferSerde implements Serde<ByteBuffer> {
}
}
+ @Override
public ByteBuffer fromBytes(byte[] bytes) {
if (bytes != null) {
return ByteBuffer.wrap(bytes);
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/ByteBufferSerdeFactory.java b/samza-api/src/main/java/org/apache/samza/serializers/ByteBufferSerdeFactory.java
index 0fcaa86..247a3c6 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/ByteBufferSerdeFactory.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/ByteBufferSerdeFactory.java
@@ -25,6 +25,7 @@ import java.nio.ByteBuffer;
public class ByteBufferSerdeFactory implements SerdeFactory<ByteBuffer> {
+ @Override
public Serde<ByteBuffer> getSerde(String name, Config config) {
return new ByteBufferSerde();
}
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/ByteSerde.java b/samza-api/src/main/java/org/apache/samza/serializers/ByteSerde.java
index ea7156c..e652e6c 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/ByteSerde.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/ByteSerde.java
@@ -24,10 +24,12 @@ package org.apache.samza.serializers;
*/
public class ByteSerde implements Serde<byte[]> {
+ @Override
public byte[] toBytes(byte[] bytes) {
return bytes;
}
+ @Override
public byte[] fromBytes(byte[] bytes) {
return bytes;
}
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/ByteSerdeFactory.java b/samza-api/src/main/java/org/apache/samza/serializers/ByteSerdeFactory.java
index 5c4ad05..d3f0074 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/ByteSerdeFactory.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/ByteSerdeFactory.java
@@ -23,6 +23,7 @@ import org.apache.samza.config.Config;
public class ByteSerdeFactory implements SerdeFactory<byte[]> {
+ @Override
public Serde<byte[]> getSerde(String name, Config config) {
return new ByteSerde();
}
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/DoubleSerde.java b/samza-api/src/main/java/org/apache/samza/serializers/DoubleSerde.java
index 39de72b..b505a55 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/DoubleSerde.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/DoubleSerde.java
@@ -26,6 +26,7 @@ import java.nio.ByteBuffer;
*/
public class DoubleSerde implements Serde<Double> {
+ @Override
public byte[] toBytes(Double obj) {
if (obj != null) {
return ByteBuffer.allocate(8).putDouble(obj).array();
@@ -35,6 +36,7 @@ public class DoubleSerde implements Serde<Double> {
}
// big-endian by default
+ @Override
public Double fromBytes(byte[] bytes) {
if (bytes != null) {
return ByteBuffer.wrap(bytes).getDouble();
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/DoubleSerdeFactory.java b/samza-api/src/main/java/org/apache/samza/serializers/DoubleSerdeFactory.java
index 18247d6..d774faa 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/DoubleSerdeFactory.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/DoubleSerdeFactory.java
@@ -23,6 +23,7 @@ import org.apache.samza.config.Config;
public class DoubleSerdeFactory implements SerdeFactory<Double> {
+ @Override
public Serde<Double> getSerde(String name, Config config) {
return new DoubleSerde();
}
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/IntegerSerde.java b/samza-api/src/main/java/org/apache/samza/serializers/IntegerSerde.java
index d2716b0..26a56ef 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/IntegerSerde.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/IntegerSerde.java
@@ -26,6 +26,7 @@ import java.nio.ByteBuffer;
*/
public class IntegerSerde implements Serde<Integer> {
+ @Override
public byte[] toBytes(Integer obj) {
if (obj != null) {
return ByteBuffer.allocate(4).putInt(obj).array();
@@ -35,6 +36,7 @@ public class IntegerSerde implements Serde<Integer> {
}
// big-endian by default
+ @Override
public Integer fromBytes(byte[] bytes) {
if (bytes != null) {
return ByteBuffer.wrap(bytes).getInt();
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/IntegerSerdeFactory.java b/samza-api/src/main/java/org/apache/samza/serializers/IntegerSerdeFactory.java
index 34f8d55..a2f875d 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/IntegerSerdeFactory.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/IntegerSerdeFactory.java
@@ -23,6 +23,7 @@ import org.apache.samza.config.Config;
public class IntegerSerdeFactory implements SerdeFactory<Integer> {
+ @Override
public Serde<Integer> getSerde(String name, Config config) {
return new IntegerSerde();
}
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/JsonSerdeV2.java b/samza-api/src/main/java/org/apache/samza/serializers/JsonSerdeV2.java
index 99adc86..e5ccf3e 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/JsonSerdeV2.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/JsonSerdeV2.java
@@ -71,6 +71,7 @@ public class JsonSerdeV2<T> implements Serde<T> {
return new JsonSerdeV2<>(clazz);
}
+ @Override
public byte[] toBytes(T obj) {
if (obj != null) {
try {
@@ -84,6 +85,7 @@ public class JsonSerdeV2<T> implements Serde<T> {
}
}
+ @Override
public T fromBytes(byte[] bytes) {
if (bytes != null) {
String str;
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/JsonSerdeV2Factory.java b/samza-api/src/main/java/org/apache/samza/serializers/JsonSerdeV2Factory.java
index 2058e6b..d21abd9 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/JsonSerdeV2Factory.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/JsonSerdeV2Factory.java
@@ -22,6 +22,7 @@ package org.apache.samza.serializers;
import org.apache.samza.config.Config;
public class JsonSerdeV2Factory implements SerdeFactory<Object> {
+ @Override
public JsonSerdeV2<Object> getSerde(String name, Config config) {
return new JsonSerdeV2<>();
}
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/KVSerde.java b/samza-api/src/main/java/org/apache/samza/serializers/KVSerde.java
index 42a527d..a88a61a 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/KVSerde.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/KVSerde.java
@@ -49,6 +49,7 @@ public class KVSerde<K, V> implements Serde<KV<K, V>> {
return new KVSerde<>(keySerde, valueSerde);
}
+ @Override
public KV<K, V> fromBytes(byte[] bytes) {
if (bytes != null) {
ByteBuffer byteBuffer = ByteBuffer.wrap(bytes);
@@ -66,6 +67,7 @@ public class KVSerde<K, V> implements Serde<KV<K, V>> {
}
}
+ @Override
public byte[] toBytes(KV<K, V> obj) {
if (obj != null) {
byte[] keyBytes = keySerde.toBytes(obj.key);
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/LongSerde.java b/samza-api/src/main/java/org/apache/samza/serializers/LongSerde.java
index fb61380..b5fe689 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/LongSerde.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/LongSerde.java
@@ -26,6 +26,7 @@ import java.nio.ByteBuffer;
*/
public class LongSerde implements Serde<Long> {
+ @Override
public byte[] toBytes(Long obj) {
if (obj != null) {
return ByteBuffer.allocate(8).putLong(obj).array();
@@ -35,6 +36,7 @@ public class LongSerde implements Serde<Long> {
}
// big-endian by default
+ @Override
public Long fromBytes(byte[] bytes) {
if (bytes != null) {
return ByteBuffer.wrap(bytes).getLong();
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/LongSerdeFactory.java b/samza-api/src/main/java/org/apache/samza/serializers/LongSerdeFactory.java
index e2ae811..4cd7281 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/LongSerdeFactory.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/LongSerdeFactory.java
@@ -23,6 +23,7 @@ import org.apache.samza.config.Config;
public class LongSerdeFactory implements SerdeFactory<Long> {
+ @Override
public LongSerde getSerde(String name, Config config) {
return new LongSerde();
}
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/NoOpSerde.java b/samza-api/src/main/java/org/apache/samza/serializers/NoOpSerde.java
index b7faef9..a0f29b8 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/NoOpSerde.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/NoOpSerde.java
@@ -29,11 +29,13 @@ import org.apache.samza.SamzaException;
*/
public class NoOpSerde<T> implements Serde<T> {
+ @Override
public T fromBytes(byte[] bytes) {
throw new SamzaException("NoOpSerde fromBytes should not be invoked by the framework.");
}
+ @Override
public byte[] toBytes(T obj) {
throw new SamzaException("NoOpSerde toBytes should not be invoked by the framework.");
}
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/SerializableSerde.java b/samza-api/src/main/java/org/apache/samza/serializers/SerializableSerde.java
index d49518c..e2d6ee4 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/SerializableSerde.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/SerializableSerde.java
@@ -34,6 +34,7 @@ import java.io.Serializable;
*/
public class SerializableSerde<T extends Serializable> implements Serde<T> {
+ @Override
public byte[] toBytes(T obj) {
if (obj != null) {
ByteArrayOutputStream bos = new ByteArrayOutputStream();
@@ -59,6 +60,7 @@ public class SerializableSerde<T extends Serializable> implements Serde<T> {
}
}
+ @Override
public T fromBytes(byte[] bytes) {
if (bytes != null) {
ByteArrayInputStream bis = new ByteArrayInputStream(bytes);
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/SerializableSerdeFactory.java b/samza-api/src/main/java/org/apache/samza/serializers/SerializableSerdeFactory.java
index 2bc78b5..2d6164c 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/SerializableSerdeFactory.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/SerializableSerdeFactory.java
@@ -25,6 +25,7 @@ import java.io.Serializable;
public class SerializableSerdeFactory<T extends Serializable> implements SerdeFactory<T> {
+ @Override
public Serde<T> getSerde(String name, Config config) {
return new SerializableSerde<>();
}
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/StringSerde.java b/samza-api/src/main/java/org/apache/samza/serializers/StringSerde.java
index c2c2874..ae83135 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/StringSerde.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/StringSerde.java
@@ -38,6 +38,7 @@ public class StringSerde implements Serde<String> {
this("UTF-8");
}
+ @Override
public byte[] toBytes(String obj) {
if (obj != null) {
try {
@@ -50,6 +51,7 @@ public class StringSerde implements Serde<String> {
}
}
+ @Override
public String fromBytes(byte[] bytes) {
if (bytes != null) {
try {
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/StringSerdeFactory.java b/samza-api/src/main/java/org/apache/samza/serializers/StringSerdeFactory.java
index 2f61fe1..618d99b 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/StringSerdeFactory.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/StringSerdeFactory.java
@@ -23,6 +23,7 @@ import org.apache.samza.config.Config;
public class StringSerdeFactory implements SerdeFactory<String> {
+ @Override
public Serde<String> getSerde(String name, Config config) {
return new StringSerde(config.get("encoding", "UTF-8"));
}
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/UUIDSerde.java b/samza-api/src/main/java/org/apache/samza/serializers/UUIDSerde.java
index 3cd681f..ac3d860 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/UUIDSerde.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/UUIDSerde.java
@@ -27,6 +27,7 @@ import java.util.UUID;
*/
public class UUIDSerde implements Serde<UUID> {
+ @Override
public byte[] toBytes(UUID obj) {
if (obj != null) {
return ByteBuffer.allocate(16)
@@ -38,6 +39,7 @@ public class UUIDSerde implements Serde<UUID> {
}
}
+ @Override
public UUID fromBytes(byte[] bytes) {
if (bytes != null) {
ByteBuffer buffer = ByteBuffer.wrap(bytes);
diff --git a/samza-api/src/main/java/org/apache/samza/serializers/UUIDSerdeFactory.java b/samza-api/src/main/java/org/apache/samza/serializers/UUIDSerdeFactory.java
index 4394824..15e3a83 100644
--- a/samza-api/src/main/java/org/apache/samza/serializers/UUIDSerdeFactory.java
+++ b/samza-api/src/main/java/org/apache/samza/serializers/UUIDSerdeFactory.java
@@ -25,6 +25,7 @@ import java.util.UUID;
public class UUIDSerdeFactory implements SerdeFactory<UUID> {
+ @Override
public Serde<UUID> getSerde(String name, Config config) {
return new UUIDSerde();
}
diff --git a/samza-api/src/main/java/org/apache/samza/system/BoundedSSPIterator.java b/samza-api/src/main/java/org/apache/samza/system/BoundedSSPIterator.java
index b92d6cf..5dadf98 100644
--- a/samza-api/src/main/java/org/apache/samza/system/BoundedSSPIterator.java
+++ b/samza-api/src/main/java/org/apache/samza/system/BoundedSSPIterator.java
@@ -53,12 +53,14 @@ public class BoundedSSPIterator implements Iterator<IncomingMessageEnvelope> {
this.peeks = new ArrayDeque<>();
}
+ @Override
public boolean hasNext() {
refresh();
return peeks.size() > 0 && (endOffset == null || admin.offsetComparator(peeks.peek().getOffset(), endOffset) <= 0);
}
+ @Override
public IncomingMessageEnvelope next() {
refresh();
diff --git a/samza-api/src/main/java/org/apache/samza/system/chooser/BaseMessageChooser.java b/samza-api/src/main/java/org/apache/samza/system/chooser/BaseMessageChooser.java
index 659362b..18277b5 100644
--- a/samza-api/src/main/java/org/apache/samza/system/chooser/BaseMessageChooser.java
+++ b/samza-api/src/main/java/org/apache/samza/system/chooser/BaseMessageChooser.java
@@ -26,12 +26,15 @@ import org.apache.samza.system.SystemStreamPartition;
* that don't use them.
*/
abstract public class BaseMessageChooser implements MessageChooser {
+ @Override
public void start() {
}
+ @Override
public void stop() {
}
+ @Override
public void register(SystemStreamPartition systemStreamPartition, String offset) {
}
}
diff --git a/samza-api/src/main/java/org/apache/samza/util/BlockingEnvelopeMap.java b/samza-api/src/main/java/org/apache/samza/util/BlockingEnvelopeMap.java
index d80b2a4..7ec2efe 100644
--- a/samza-api/src/main/java/org/apache/samza/util/BlockingEnvelopeMap.java
+++ b/samza-api/src/main/java/org/apache/samza/util/BlockingEnvelopeMap.java
@@ -77,6 +77,7 @@ public abstract class BlockingEnvelopeMap implements SystemConsumer {
public BlockingEnvelopeMap(MetricsRegistry metricsRegistry) {
this(metricsRegistry, new Clock() {
+ @Override
public long currentTimeMillis() {
return System.currentTimeMillis();
}