[jira] [Commented] (BEAM-3348) Beam SQL DSL not support non-ascii characters in sql

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290305#comment-16290305 ] 

ASF GitHub Bot commented on BEAM-3348:
--------------------------------------

Alienero opened a new pull request #4258: [BEAM-3348] Set utf-16 as SQL DSL default charset
URL: https://github.com/apache/beam/pull/4258
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Beam SQL DSL not support non-ascii characters in sql
> ----------------------------------------------------
>
>                 Key: BEAM-3348
>                 URL: https://issues.apache.org/jira/browse/BEAM-3348
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>    Affects Versions: 2.2.0
>            Reporter: Yiyan Lu
>            Assignee: Xu Mingmin
>             Fix For: 2.2.0
>
>
> When I have non-ascii in Beam SQL:
> ```
> SELECT * FROM TABLE_A WHERE f_string = '第四行'
> ```
>  calcite planner will throw exception:
> ```
> Caused by: org.apache.calcite.runtime.CalciteException: Failed to encode '第四行' in character set 'ISO-8859-1'
> ```
> cause by calcite using ISO-8859-1 for default charset



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)