[GitHub] [superset] lilykuang commented on a change in pull request #19031: feat(embedded): add optional dashboard ui configuration

[GitBox <gi...@apache.org>]

lilykuang commented on a change in pull request #19031:
URL: https://github.com/apache/superset/pull/19031#discussion_r822121030



##########
File path: superset-embedded-sdk/src/index.ts
##########
@@ -38,6 +38,8 @@ export type EmbedDashboardParams = {
   mountPoint: HTMLElement
   /** A function to fetch a guest token from the Host App's backend server */
   fetchGuestToken: GuestTokenFetchFn
+  /** The dashboard UI config: hideTitle: 1; hideTab: 2; hideNav: 4; hideChartControls: 8; **/
+  uiConfig?: number

Review comment:
       ```
   uiConfig: {
       hideTitle: boolean
       hideTab: boolean
       hideNav: boolean 
       hideChartControls: boolean
   }
   ```
   something like this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org