You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by medcv <gi...@git.apache.org> on 2018/05/13 05:43:38 UTC
[GitHub] flink pull request #6000: [FLINK-9299] [Documents] ProcessWindowFunction doc...
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6000
[FLINK-9299] [Documents] ProcessWindowFunction documentation Java examples have error
## What is the purpose of the change
ProcessWindowFunction documentation Java examples have error
## Brief change log
ProcessWindowFunction is an abstract class and should extends instead of implements
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/medcv/flink patch-5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6000.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6000
----
commit aa26f9a08c5938eae31833a73e42e82cb213e59f
Author: Yazdan.JS <y_...@...>
Date: 2018-05-13T05:40:39Z
[FLINK-9299] ProcessWindowFunction documentation Java examples have errors
----
---
[GitHub] flink issue #6000: [FLINK-9299] [Documents] ProcessWindowFunction documentat...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/6000
Congrats on having PR number 6000!
This overlaps with #6001, which is a mit more comprehensive (but need some improvements).
Would you be up to coordinate to make one joint PR?
---
[GitHub] flink issue #6000: [FLINK-9299] [Documents] ProcessWindowFunction documentat...
Posted by medcv <gi...@git.apache.org>.
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6000
@StephanEwen Thanks
Yes, I made this PR before asking about ticket status. my bad!
I will close it and will work on #6001
---
[GitHub] flink pull request #6000: [FLINK-9299] [Documents] ProcessWindowFunction doc...
Posted by medcv <gi...@git.apache.org>.
Github user medcv closed the pull request at:
https://github.com/apache/flink/pull/6000
---
[GitHub] flink pull request #6000: [FLINK-9299] [Documents] ProcessWindowFunction doc...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/6000#discussion_r187798729
--- Diff: docs/dev/stream/operators/windows.md ---
@@ -730,9 +730,9 @@ input
/* ... */
-public class MyProcessWindowFunction implements ProcessWindowFunction<Tuple<String, Long>, String, String, TimeWindow> {
+public static class MyProcessWindowFunction extends ProcessWindowFunction<Tuple<String, Long>, String, String, TimeWindow> {
--- End diff --
In other code samples, we don't put the `static`, not assuming that this is defined as an inner class
---
[GitHub] flink pull request #6000: [FLINK-9299] [Documents] ProcessWindowFunction doc...
Posted by medcv <gi...@git.apache.org>.
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6000#discussion_r187802397
--- Diff: docs/dev/stream/operators/windows.md ---
@@ -730,9 +730,9 @@ input
/* ... */
-public class MyProcessWindowFunction implements ProcessWindowFunction<Tuple<String, Long>, String, String, TimeWindow> {
+public static class MyProcessWindowFunction extends ProcessWindowFunction<Tuple<String, Long>, String, String, TimeWindow> {
--- End diff --
make sense!
I see some `static` in this docs for other examples, we might need to make them consistent
`private static class MyReduceFunction implements ReduceFunction<SensorReading> {`
---