You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/01 03:54:42 UTC

[GitHub] dilipbiswal commented on a change in pull request #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.

dilipbiswal commented on a change in pull request #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.
URL: https://github.com/apache/spark/pull/23883#discussion_r261472524
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
 ##########
 @@ -516,6 +505,35 @@ case class DescribeTableCommand(
       new MetadataBuilder().putString("comment", "comment of the column").build())()
   )
 
+  def describeSchema(
 
 Review comment:
   @maropu describeSchema has two callers. One from the describeTable code path and one from describeQuery. The other caller passes the row buffer. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org