[jira] [Commented] (BOOKKEEPER-709) SlowBookieTest#testSlowBookie fails intermittently

["Rakesh R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830555#comment-13830555 ] 

Rakesh R commented on BOOKKEEPER-709:
-------------------------------------

*Cause:* Since bookie.suspendProcessing(); is inside another thread and is not guaranteed to be suspended before adding an entry by main thread. I've reproduced by putting some sleep before suspending.

 Attached patch which does bookie.suspendProcessing(); in the main thread, also have done few improvements
- added debug logs
- modified assertion parameters
- replaced thread.sleep with latch

Please review the changes. Thanks


> SlowBookieTest#testSlowBookie fails intermittently
> --------------------------------------------------
>
>                 Key: BOOKKEEPER-709
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-709
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-709.patch
>
>
> SlowBookieTest#testSlowBookie fails intermittently when verifying the result of addEntry. 
> {code}
> junit.framework.AssertionFailedError: expected:<0> but was:<-559038737>
> 	at junit.framework.Assert.fail(Assert.java:47)
> 	at junit.framework.Assert.failNotEquals(Assert.java:283)
> 	at junit.framework.Assert.assertEquals(Assert.java:64)
> 	at junit.framework.Assert.assertEquals(Assert.java:195)
> 	at junit.framework.Assert.assertEquals(Assert.java:201)
> 	at org.apache.bookkeeper.client.SlowBookieTest.testSlowBookie(SlowBookieTest.java:82)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)