You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/27 00:40:00 UTC

[GitHub] [apisix-ingress-controller] tokers commented on a diff in pull request #1046: e2e-test: upgrade to ginkgo v2

tokers commented on code in PR #1046:
URL: https://github.com/apache/apisix-ingress-controller/pull/1046#discussion_r883186560


##########
test/e2e/go.mod:
##########
@@ -8,7 +8,7 @@ require (
 	github.com/gavv/httpexpect/v2 v2.2.0
 	github.com/gorilla/websocket v1.4.2
 	github.com/gruntwork-io/terratest v0.32.8
-	github.com/onsi/ginkgo v1.16.4
+	github.com/onsi/ginkgo/v2 v2.1.4

Review Comment:
   Can we use `replace` directive so that we can avoid a lot of changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org