You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/26 10:41:47 UTC

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3947: [Enhance] Add prepare phase for some timestamp functions

wutiangan commented on a change in pull request #3947:
URL: https://github.com/apache/incubator-doris/pull/3947#discussion_r446108091



##########
File path: be/src/exprs/timestamp_functions.cpp
##########
@@ -599,7 +673,7 @@ IntVal TimestampFunctions::to_unix(
 
 DateTimeVal TimestampFunctions::utc_timestamp(FunctionContext* context) {
     DateTimeValue dtv;
-    if (!dtv.from_unixtime(context->impl()->state()->timestamp_ms() / 1000, "+00:00")) {
+    if (!dtv.from_unixtime(context->impl()->state()->timestamp_ms() / 1000, "+0:00")) {

Review comment:
       why "+00:00" modify to "+0:00"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org