You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "timsaucer (via GitHub)" <gi...@apache.org> on 2026/03/12 08:56:29 UTC
[PR] Update datafusion dependency to 52.3.0 [datafusion-python]
timsaucer opened a new pull request, #1425:
URL: https://github.com/apache/datafusion-python/pull/1425
# Which issue does this PR close?
None
# Rationale for this change
This PR only updates the datafusion dependency to 52.3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update datafusion dependency to 52.3.0 [datafusion-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #1425:
URL: https://github.com/apache/datafusion-python/pull/1425#discussion_r2926507339
##########
src/lib.rs:
##########
@@ -16,9 +16,9 @@
// under the License.
// Re-export Apache Arrow DataFusion dependencies
-pub use datafusion;
pub use datafusion::{
Review Comment:
nit: ive been seeing a lot of these changes across PRs, is there something we can run for the entire repo? or configure the linter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update datafusion dependency to 52.3.0 [datafusion-python]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer merged PR #1425:
URL: https://github.com/apache/datafusion-python/pull/1425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update datafusion dependency to 52.3.0 [datafusion-python]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer commented on code in PR #1425:
URL: https://github.com/apache/datafusion-python/pull/1425#discussion_r2927305314
##########
src/lib.rs:
##########
@@ -16,9 +16,9 @@
// under the License.
// Re-export Apache Arrow DataFusion dependencies
-pub use datafusion;
pub use datafusion::{
Review Comment:
It's a change in the nightly `cargo fmt`, probably from the new rust release. If we do, then we'd need to turn off the `group_imports` and `imports_granularity` in `rustfmt.toml`. I suppose we could do that and just have it turned on in the pre-commit. That just means that any contributors who do have that turned on will end up with more formatting changes than others. Or we could take those out, but personally I think it does make the repo cleaner. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update datafusion dependency to 52.3.0 [datafusion-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #1425:
URL: https://github.com/apache/datafusion-python/pull/1425#discussion_r2932934472
##########
src/lib.rs:
##########
@@ -16,9 +16,9 @@
// under the License.
// Re-export Apache Arrow DataFusion dependencies
-pub use datafusion;
pub use datafusion::{
Review Comment:
ah its already part of pre-commit (we're using `cargo +nightly fmt`) [here](https://github.com/apache/datafusion-python/blob/1160d5a91d586927dc6e466829965770c3fa299a/.pre-commit-config.yaml#L36)
I see the change is already applied [in the main branch](https://github.com/apache/datafusion-python/blob/1160d5a91d586927dc6e466829965770c3fa299a/src/lib.rs#L18-L22).
We're seeing this change again because this PR targets the `apache:branch-52` branch.
Ignore my comment 😄 everything looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update datafusion dependency to 52.3.0 [datafusion-python]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer commented on PR #1425:
URL: https://github.com/apache/datafusion-python/pull/1425#issuecomment-4066853945
Thanks @kevinjqliu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org