You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/29 14:15:06 UTC

[GitHub] [spark] rezasafi commented on issue #23767: [SPARK-26329][CORE] Faster polling of executor memory metrics.

rezasafi commented on issue #23767: [SPARK-26329][CORE] Faster polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#issuecomment-478012993
 
 
   > There is no new heartbeat. There is still the same heartbeat as before, doing the same thing as before (including sending the executor metrics).
   Thank you again for your work here. This change is using a heartbeat pattern. That's what I meant. It is suggesting to send a new  heartbeat to  executors for pulling metrics faster when it is needed. I saw the discussion above, but since there is not an overhead analysis reported here, it is really hard to say whether there is no advantage of just using the original heartbeat comparing to introducing a new thread and also adding several concurrency related stuff.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org