You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/01 09:00:48 UTC
[GitHub] [superset] maloun96 opened a new pull request #12859: Add inclusive and exclusive text for date start and end
maloun96 opened a new pull request #12859:
URL: https://github.com/apache/superset/pull/12859
### SUMMARY
Add tooltip for start and end date in datepicker (inclusive, exclusive)
## BEFORE
## AFTER
### TEST PLAN
Create new Time series e chart
Select "Time range"
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
- [x] Close: https://github.com/apache/superset/issues/12784
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] maloun96 closed pull request #12859: fix: Add inclusive and exclusive text for date start and end
Posted by GitBox <gi...@apache.org>.
maloun96 closed pull request #12859:
URL: https://github.com/apache/superset/pull/12859
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] maloun96 commented on a change in pull request #12859: Add inclusive and exclusive text for date start and end
Posted by GitBox <gi...@apache.org>.
maloun96 commented on a change in pull request #12859:
URL: https://github.com/apache/superset/pull/12859#discussion_r567661167
##########
File path: superset-frontend/src/explore/components/controls/DateFilterControl/frame/AdvancedFrame.tsx
##########
@@ -20,6 +20,7 @@ import React from 'react';
import { t } from '@superset-ui/core';
import { SEPARATOR } from 'src/explore/dateFilterUtils';
import { Input } from 'src/common/components';
+import { InfoTooltipWithTrigger } from '@superset-ui/chart-controls';
Review comment:
The reason I added InfoTooltipWithTrigger instead of InfoTooltip is from style
Start = InfoTooltip
End = InfoTooltipWithTrigger
and it doesn't make sense to create custom styles for control label.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12859: Fix: Add inclusive and exclusive text for date start and end
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12859:
URL: https://github.com/apache/superset/pull/12859#issuecomment-770723206
# [Codecov](https://codecov.io/gh/apache/superset/pull/12859?src=pr&el=h1) Report
> Merging [#12859](https://codecov.io/gh/apache/superset/pull/12859?src=pr&el=desc) (f3f78a9) into [master](https://codecov.io/gh/apache/superset/commit/9a7fba810e5bc3a94746117937163c1bfaea19ee?el=desc) (9a7fba8) will **decrease** coverage by `3.64%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12859?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12859 +/- ##
==========================================
- Coverage 67.04% 63.39% -3.65%
==========================================
Files 1022 489 -533
Lines 50186 30193 -19993
Branches 5204 0 -5204
==========================================
- Hits 33647 19141 -14506
+ Misses 16404 11052 -5352
+ Partials 135 0 -135
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.39% <ø> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12859?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12859/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12859/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12859/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12859/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12859/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12859/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12859/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12859/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12859/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12859/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.59% <0.00%> (-3.27%)` | :arrow_down: |
| ... and [542 more](https://codecov.io/gh/apache/superset/pull/12859/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12859?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12859?src=pr&el=footer). Last update [9a7fba8...f3f78a9](https://codecov.io/gh/apache/superset/pull/12859?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #12859: fix: Add inclusive and exclusive text for start date and end date
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #12859:
URL: https://github.com/apache/superset/pull/12859
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12859: fix: Add inclusive and exclusive text for start date and end date
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12859:
URL: https://github.com/apache/superset/pull/12859#issuecomment-773078593
LGTM!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12859: fix: Add inclusive and exclusive text for start date and end date
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12859:
URL: https://github.com/apache/superset/pull/12859#issuecomment-773078593
LGTM!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #12859: Fix: Add inclusive and exclusive text for date start and end
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #12859:
URL: https://github.com/apache/superset/pull/12859#issuecomment-770708285
@maloun96 run following command to fix lint
```shell
cd superset-frontend
npm run lint-fix
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #12859: fix: Add inclusive and exclusive text for start date and end date
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #12859:
URL: https://github.com/apache/superset/pull/12859
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] maloun96 commented on a change in pull request #12859: Fix: Add inclusive and exclusive text for date start and end
Posted by GitBox <gi...@apache.org>.
maloun96 commented on a change in pull request #12859:
URL: https://github.com/apache/superset/pull/12859#discussion_r567661167
##########
File path: superset-frontend/src/explore/components/controls/DateFilterControl/frame/AdvancedFrame.tsx
##########
@@ -20,6 +20,7 @@ import React from 'react';
import { t } from '@superset-ui/core';
import { SEPARATOR } from 'src/explore/dateFilterUtils';
import { Input } from 'src/common/components';
+import { InfoTooltipWithTrigger } from '@superset-ui/chart-controls';
Review comment:
The reason I added InfoTooltipWithTrigger instead of InfoTooltip is from style
Start = InfoTooltip
End = InfoTooltipWithTrigger
and it doesn't make sense to create custom styles for the control label to arrange the tooltip icon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org