You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Tsuyoshi OZAWA (JIRA)" <ji...@apache.org> on 2014/05/30 03:27:01 UTC

[jira] [Comment Edited] (TEZ-373) Create UserPayload class

    [ https://issues.apache.org/jira/browse/TEZ-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013179#comment-14013179 ] 

Tsuyoshi OZAWA edited comment on TEZ-373 at 5/30/14 1:25 AM:
-------------------------------------------------------------

{quote}
Shouldn't this simply be "return userPayload.getPayload()"?
{quote}

Yes, it's simpler approach. Then, should we remove {{DagTypeConverters.convertFromTezUserPayload()}} for now? If we remove convertFromTezUserPayload(), TezEntityDescriptor needs to check null itself:
{code}
byte[] bb = (userPayload == null) ? null : userPayload.getPayload();
{code}


was (Author: ozawa):
{quote}
Shouldn't this simply be "return userPayload.getPayload()"?
{quote}

Yes, it's simpler approach. Then, should we remove {{DagTypeConverters.convertFromTezUserPayload()}} for now?

> Create UserPayload class
> ------------------------
>
>                 Key: TEZ-373
>                 URL: https://issues.apache.org/jira/browse/TEZ-373
>             Project: Apache Tez
>          Issue Type: Task
>            Reporter: Bikas Saha
>            Assignee: Tsuyoshi OZAWA
>              Labels: newbie
>         Attachments: TEZ-373.1.patch, TEZ-373.10.patch, TEZ-373.2.patch, TEZ-373.3.patch, TEZ-373.4.patch, TEZ-373.5.patch, TEZ-373.6.patch, TEZ-373.7.patch, TEZ-373.8.patch, TEZ-373.9.patch
>
>
> Currently Tez allows user payload to be passed as byte[]. Within Tez code is hard to understand where byte[] is userPayload and where is not user payload. If we create a TezUserPayload class that contains byte[] as a member then its much easier to search and identify in code.



--
This message was sent by Atlassian JIRA
(v6.2#6252)