You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Thomas Jaeckle (JIRA)" <ji...@apache.org> on 2007/12/11 13:15:43 UTC

[jira] Issue Comment Edited: (WICKET-1210) Proposal to remove 'final' modifier for PagingNavigationIncrementLink.getPageNumber()

    [ https://issues.apache.org/jira/browse/WICKET-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550350 ] 

maentele edited comment on WICKET-1210 at 12/11/07 4:14 AM:
------------------------------------------------------------------

I did 
((DataTable)pageable).detach();
as you suggested, but that doesn't clear the cached page count of the DataGridView in DataTable

I just noticed that overriding PagingNavigationIncrementLink.getPageNumber() would not help me, because the cachedItemCount in AbstractPageableView has still the old value. But I also don't see how I update or clear the cache ...

      was (Author: maentele):
    I did 
((DataTable)pageable).detach();
as you suggested, but that doesn't clear the cached page count of the DataGridView in DataTable
  
> Proposal to remove 'final' modifier for PagingNavigationIncrementLink.getPageNumber()
> -------------------------------------------------------------------------------------
>
>                 Key: WICKET-1210
>                 URL: https://issues.apache.org/jira/browse/WICKET-1210
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Thomas Jaeckle
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.3.0-rc3
>
>
> I wish to add a special behaviour to "PagingNavigationIncrementLink.getPageNumber()", which is final:
> http://www.nabble.com/PagingNavigationIncrementLink-special-behaviour-tf4935583.html
> Short: I extended "PagingNavigationIncrementLink.onClick()" so that more data is loaded from a service. After that I still want that the Page is changed, so I call "pageable.setCurrentPage(getPageNumber());".
> The "return Math.max(0, Math.min(pageable.getPageCount() - 1, idx));" breaks my neck because "pageable.getPageCount()" is missing the new added Page.
> It would be very helpful if PagingNavigationIncrementLink.getPageNumber() would not be final.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.