[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #994: Enable HiveOnSpark queries for RT tables

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #994: Enable HiveOnSpark queries for RT tables
URL: https://github.com/apache/incubator-hudi/pull/994#discussion_r342235194
 
 

 ##########
 File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieParquetRealtimeInputFormat.java
 ##########
 @@ -203,14 +204,12 @@ private static synchronized Configuration addRequiredProjectionFields(Configurat
    * e.g. ",2,0,3" and will cause an error. Actually this method is a temporary solution because the real bug is from
    * Hive. Hive has fixed this bug after 3.0.0, but the version before that would still face this problem. (HIVE-22438)
    */
-  private static Configuration cleanProjectionColumnIds(Configuration conf) {
-    synchronized (conf) {
-      String columnIds = conf.get(ColumnProjectionUtils.READ_COLUMN_IDS_CONF_STR);
-      if (!columnIds.isEmpty() && columnIds.charAt(0) == ',') {
-        conf.set(ColumnProjectionUtils.READ_COLUMN_IDS_CONF_STR, columnIds.substring(1));
-        if (LOG.isDebugEnabled()) {
-          LOG.debug("The projection Ids: {" + columnIds + "} start with ','. First comma is removed");
-        }
+  private Configuration cleanProjectionColumnIds(Configuration conf) {
 
 Review comment:
   keep it static? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services