You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/11 18:38:36 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26853:
[SPARK-30104][SQL][FOLLOWUP] Replace CatalogObjectIdentifier with
CatalogAndIdentifier
dongjoon-hyun commented on a change in pull request #26853: [SPARK-30104][SQL][FOLLOWUP] Replace CatalogObjectIdentifier with CatalogAndIdentifier
URL: https://github.com/apache/spark/pull/26853#discussion_r356766401
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -357,11 +357,11 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
val canUseV2 = lookupV2Provider().isDefined
session.sessionState.sqlParser.parseMultipartIdentifier(tableName) match {
- case CatalogObjectIdentifier(catalog, ident) if !isSessionCatalog(catalog) =>
+ case NonSessionCatalogAndIdentifier(catalog, ident) =>
Review comment:
I like this change. Could you update the PR description more precisely?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org