You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Varun Saxena (JIRA)" <ji...@apache.org> on 2016/12/06 11:11:27 UTC
[jira] [Comment Edited] (YARN-5647) [Security] Collector and reader
side changes for loading auth filters and principals
[ https://issues.apache.org/jira/browse/YARN-5647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724926#comment-15724926 ]
Varun Saxena edited comment on YARN-5647 at 12/6/16 9:33 AM:
-------------------------------------------------------------
I was actually attempting to remove setupOptions but soon realised that due to mismatch in hadoop-common versions with HBase, there will be runtime errors. Changed it to addFilters because we were only adding timeline filter in this method so thought this might be a more suitable name.
bq. I assume that you're still working on the unit tests for this?
I have added a E2E UT in YARN-5648 which includes some client side changes (most changes already existed because we were already reusing relevant code written during ATSv1).
bq. Also, can you please fix the checkstyle issues? Seems straightforward enough.
Sure. If the patch overall is fine, I think we need to move Timeline auth filter and related classes to hadoop-yarn-server-common. Referring it from hadoop-yarn-applicationhistoryservice does not seem correct.
Thought of fixing checkstyle alongwith that refactoring.
was (Author: varun_saxena):
I was actually attempting to remove setupOptions but soon realised that due to mismatch in hadoop-common versions with HBase, there will be runtime errors. Changed it to addFilters because we were only adding timeline filter in this method so thought this might be a more suitable name.
bq. I assume that you're still working on the unit tests for this?
I have added a E2E UT in YARN-5648 which includes client side changes (most changes already exist).
bq. Also, can you please fix the checkstyle issues? Seems straightforward enough.
Sure. If the patch overall is fine, I think we need to move Timeline auth filter and related classes to hadoop-yarn-server-common. Referring it from hadoop-yarn-applicationhistoryservice does not seem correct.
Thought of fixing checkstyle alongwith that refactoring.
> [Security] Collector and reader side changes for loading auth filters and principals
> ------------------------------------------------------------------------------------
>
> Key: YARN-5647
> URL: https://issues.apache.org/jira/browse/YARN-5647
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: oct16-hard
> Attachments: YARN-5647-YARN-5355.wip.002.patch, YARN-5647-YARN-5355.wip.003.patch, YARN-5647-YARN-5355.wip.01.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org