You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Amogh Vasekar <am...@citrix.com> on 2013/11/07 20:15:21 UTC
Re: Review Request 12192: set the field 'state' rather than the unread
parameter 'state', if the parameter is null
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12192/#review28418
-----------------------------------------------------------
Reminder-
Hi,
The review has been pending for long. Please update the patch since the build is failing.
Thanks
- Amogh Vasekar
On June 29, 2013, 9:08 p.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12192/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 9:08 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> code checks the parameter 'state' and if null, set it to Allocated, even though that parameter is never accessed. Meant to set the field 'state'.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0
>
> Diff: https://reviews.apache.org/r/12192/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>