[GitHub] zeppelin pull request #2727: ZEPPELIN-3137. Add code style check

[zjffdu <gi...@git.apache.org>]

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2727

    ZEPPELIN-3137. Add code style check

    ### What is this PR for?
    
    The is the first PR for adding code style check. It just adding the code style check in maven, but just disable it for now. And creating subtask under ZEPPELIN-3137 for each module.  This `checkstyle.xml` is from spark project. I think code style of spark is also fit for zeppelin project, just remove some spark related content in this `checkstyle.xml`
    
    
    ### What type of PR is it?
    [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3137
    
    ### How should this be tested?
    * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
    * Strongly recommended: add automated unit tests for any new or changed behavior
    * Outline any manual steps to test the PR here.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3137

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2727.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2727
    
----
commit e305a7a7d62ac1ed73632e3acd72a8b8e1fffa48
Author: Jeff Zhang <zj...@...>
Date:   2018-01-12T07:32:06Z

    ZEPPELIN-3137. Add code style check

----


---

[GitHub] zeppelin issue #2727: ZEPPELIN-3137. Add code style check

[zjffdu <gi...@git.apache.org>]

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2727
  
    Just update the PR to make diff more readable. @felixcheung 


---

[GitHub] zeppelin issue #2727: ZEPPELIN-3137. Improve code style check

[zjffdu <gi...@git.apache.org>]

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2727
  
    Hmm, make sense. Enable the import order checking


---

[GitHub] zeppelin pull request #2727: ZEPPELIN-3137. Improve code style check

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2727


---

[GitHub] zeppelin issue #2727: ZEPPELIN-3137. Improve code style check

[jongyoul <gi...@git.apache.org>]

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2727
  
    LGTM


---

[GitHub] zeppelin issue #2727: ZEPPELIN-3137. Add code style check

[zjffdu <gi...@git.apache.org>]

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2727
  
    I didn't check all the rules one by one. Just copy the checkstyle from spark project and remove some spark specific thing. Things like Indentation & UnusedImports is changed.


---