You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/22 07:12:07 UTC

[GitHub] [shardingsphere-elasticjob] terrymanu commented on a change in pull request #1476: Move ElasticJobListener to JobConfiguration

terrymanu commented on a change in pull request #1476:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1476#discussion_r492517002



##########
File path: elasticjob-api/src/main/java/org/apache/shardingsphere/elasticjob/api/JobConfiguration.java
##########
@@ -106,6 +111,8 @@ public static Builder newBuilder(final String jobName, final int shardingTotalCo
         private String jobExecutorServiceHandlerType;
         
         private String jobErrorHandlerType;
+    
+        private final Collection<String> jobListenerTypes = new ArrayList<>();

Review comment:
       Collection is better, HashSet is not ordered too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org