You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/17 09:44:03 UTC

[GitHub] [apisix] TkClark opened a new issue #6356: feat: the resource label could be setted by config

TkClark opened a new issue #6356:
URL: https://github.com/apache/apisix/issues/6356


   ### Issue description
   
   Now. The maximum array length of labels in schema_def.lua is 16.
   ![image](https://user-images.githubusercontent.com/10162966/154447787-7de7385b-c50c-41d8-9ec4-10171ee45649.png)
   
   Could the maximum array length be modified to the entry value in the configuration yaml


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] TkClark commented on issue #6356: feat: Could modify the max array length of labels to the entry value in the configuration yaml

Posted by GitBox <gi...@apache.org>.
TkClark commented on issue #6356:
URL: https://github.com/apache/apisix/issues/6356#issuecomment-1048479018


   yep，we just want this modified by official team. Than we can use the docker image. hahaha~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #6356: feat: Could modify the max array length of labels to the entry value in the configuration yaml

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #6356:
URL: https://github.com/apache/apisix/issues/6356#issuecomment-1043716138


   I think we can remove the limitation directly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] mangoGoForward commented on issue #6356: feat: Could modify the max array length of labels to the entry value in the configuration yaml

Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on issue #6356:
URL: https://github.com/apache/apisix/issues/6356#issuecomment-1048401210


   I'd like to tackle this issue, seems we can remove this line to remove restriction for the max array length.
   
   https://github.com/apache/apisix/blob/f7b50f28bae7ca6ed373fe7c1ea07e658a6bee3f/apisix/schema_def.lua#L97


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander closed issue #6356: feat: Could modify the max array length of labels to the entry value in the configuration yaml

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #6356:
URL: https://github.com/apache/apisix/issues/6356


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] mangoGoForward commented on issue #6356: feat: Could modify the max array length of labels to the entry value in the configuration yaml

Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on issue #6356:
URL: https://github.com/apache/apisix/issues/6356#issuecomment-1048507105


   > yep，we just want this modified by official team. Than we can use the docker image. hahaha~
   
   Maybe you can commit a PR to help official team to solve, and you can get an image what you wanted also.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org