[GitHub] dpogue commented on a change in pull request #438: Add support for EnableGoogleServicesPlugin

[GitBox <gi...@apache.org>]

dpogue commented on a change in pull request #438: Add support for EnableGoogleServicesPlugin
URL: https://github.com/apache/cordova-android/pull/438#discussion_r216195917
 
 

 ##########
 File path: bin/templates/project/app/build.gradle
 ##########
 @@ -30,6 +30,7 @@ buildscript {
 
     dependencies {
         classpath 'com.android.tools.build:gradle:3.1.0'
+        classpath 'com.google.gms:google-services:3.2.1'
 
 Review comment:
   I don't know much about Gradle, and my experience consists mostly of swearing at it.
   
   I believe you're correct that `cordova.gradle` is helper methods, but I don't know anything about scoping or when it's safe to import (apply?) stuff.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org