[GitHub] [incubator-doris] morningman commented on a change in pull request #5654: [Optimize] Make tablet meta checkpoint to be threadpool model

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #5654:
URL: https://github.com/apache/incubator-doris/pull/5654#discussion_r616602884



##########
File path: be/src/olap/olap_server.cpp
##########
@@ -290,22 +293,24 @@ void StorageEngine::_path_scan_thread_callback(DataDir* data_dir) {
     } while (!_stop_background_threads_latch.wait_for(MonoDelta::FromSeconds(interval)));
 }
 
-void StorageEngine::_tablet_checkpoint_callback(DataDir* data_dir) {
+void StorageEngine::_tablet_checkpoint_callback(std::vector<DataDir*> data_dirs) {

Review comment:
       ```suggestion
   void StorageEngine::_tablet_checkpoint_callback(const std::vector<DataDir*>& data_dirs) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org