You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Thom May <th...@planetarytramp.net> on 2002/07/02 19:49:29 UTC

[Patch] htpasswd doesn't add a newline to the end of an entry

Uh, as the title really. I guess this is a bug - it certainly isn't the old
behaviour, as far as I can tell.
Cheers,
-Thom
-- 
Thom May -> thom@planetarytramp.net

<aj> *sigh* you'd think a distribution composed of 6000
packages distributed across 13 different architectures (in various stages
between pre-alpha and release quality), maintained by 700 amateurs with often
conflicting goals who're globally distributed and have rarely met each other
-- you'd think a distribution like that would be simpler...

Index: htpasswd.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/support/htpasswd.c,v
retrieving revision 1.49
diff -u -u -r1.49 htpasswd.c
--- htpasswd.c  19 Jun 2002 17:31:19 -0000      1.49
+++ htpasswd.c  2 Jul 2002 17:51:14 -0000
@@ -236,6 +236,7 @@
     strcpy(record, user);
     strcat(record, ":");
     strcat(record, cpw);
+    strcat(record, "\n");
     return 0;
 }
 


RE: [Patch] htpasswd doesn't add a newline to the end of an entry

Posted by Cliff Woolley <jw...@virginia.edu>.
On Tue, 2 Jul 2002, Ryan Bloom wrote:

> Committed, thanks.

Due to the vast number of PR's about this, I've placed this patch in
/dist/httpd/patches/apply_to_2.0.39/

Thanks...

--Cliff


RE: [Patch] htpasswd doesn't add a newline to the end of an entry

Posted by Ryan Bloom <rb...@covalent.net>.
Committed, thanks.

Ryan

----------------------------------------------
Ryan Bloom                  rbb@covalent.net
645 Howard St.              rbb@apache.org
San Francisco, CA 

> -----Original Message-----
> From: Thom May [mailto:thom@planetarytramp.net]
> Sent: Tuesday, July 02, 2002 10:49 AM
> To: HTTPD Dev List
> Subject: [Patch] htpasswd doesn't add a newline to the end of an entry
> 
> Uh, as the title really. I guess this is a bug - it certainly isn't
the
> old
> behaviour, as far as I can tell.
> Cheers,
> -Thom
> --
> Thom May -> thom@planetarytramp.net
> 
> <aj> *sigh* you'd think a distribution composed of 6000
> packages distributed across 13 different architectures (in various
stages
> between pre-alpha and release quality), maintained by 700 amateurs
with
> often
> conflicting goals who're globally distributed and have rarely met each
> other
> -- you'd think a distribution like that would be simpler...
> 
> Index: htpasswd.c
> ===================================================================
> RCS file: /home/cvspublic/httpd-2.0/support/htpasswd.c,v
> retrieving revision 1.49
> diff -u -u -r1.49 htpasswd.c
> --- htpasswd.c  19 Jun 2002 17:31:19 -0000      1.49
> +++ htpasswd.c  2 Jul 2002 17:51:14 -0000
> @@ -236,6 +236,7 @@
>      strcpy(record, user);
>      strcat(record, ":");
>      strcat(record, cpw);
> +    strcat(record, "\n");
>      return 0;
>  }
>