[GitHub] [solr] Jdurham2843 commented on pull request #1126: SOLR-16462: Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

[GitBox <gi...@apache.org>]

Jdurham2843 commented on PR #1126:
URL: https://github.com/apache/solr/pull/1126#issuecomment-1293963646

   I believe I've covered most of your first round of comments @gerlowskija , aside from tests and the uses of the squash method on the ListSnapshotAPI. I also responded to your thoughts on the async handling code back on the jira ticket as well. I'll work to add some tests focused on this new CoreSnapshotAPI class while we work through the our async game plan.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org