You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by RobberPhex <gi...@git.apache.org> on 2016/05/31 15:23:28 UTC

[GitHub] thrift pull request: Fix THRIFT-3844

GitHub user RobberPhex opened a pull request:

    https://github.com/apache/thrift/pull/1021

    Fix THRIFT-3844

    update `php_thrift_protocol7.cpp`
    let `php_thrift_protocol` can compiled with php7.0.7 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/RobberPhex/thrift THRIFT-3844

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1021.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1021
    
----
commit fd909b86adb1841f97b961a3dc19a15c818ee85c
Author: visoeclipse <vi...@gmail.com>
Date:   2016-03-28T08:53:37Z

    Update php_thrift_protocol7.cpp
    
    bug fix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1021: Fix THRIFT-3844

Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1021
  
    @RobberPhex could you rebase this against master and re-submit to get a build that passes CI tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1021: Fix THRIFT-3844

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1021


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---