You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/07/17 19:15:22 UTC

svn commit: r1891630 - /pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/TextToPDF.java

Author: tilman
Date: Sat Jul 17 19:15:22 2021
New Revision: 1891630

URL: http://svn.apache.org/viewvc?rev=1891630&view=rev
Log:
PDFBOX-4892: simplify, as suggested by valerybokov

Modified:
    pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/TextToPDF.java

Modified: pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/TextToPDF.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/TextToPDF.java?rev=1891630&r1=1891629&r2=1891630&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/TextToPDF.java (original)
+++ pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/TextToPDF.java Sat Jul 17 19:15:22 2021
@@ -232,11 +232,8 @@ public class TextToPDF implements Callab
 
             final int margin = 40;
             float height = font.getBoundingBox().getHeight() / FONTSCALE;
-            PDRectangle actualMediaBox = mediaBox;
-            if (landscape)
-            {
-                actualMediaBox = new PDRectangle(mediaBox.getHeight(), mediaBox.getWidth());
-            }
+            PDRectangle actualMediaBox =
+                    landscape ? new PDRectangle(mediaBox.getHeight(), mediaBox.getWidth()) : mediaBox;
 
             //calculate font height and increase by a factor.
             height = height*fontSize*LINE_HEIGHT_FACTOR;
@@ -315,7 +312,7 @@ public class TextToPDF implements Callab
                                 nextWord = nextWord.substring(0, indexFF);
                             }
                             
-                            String lineWithNextWord = nextLineToDraw.toString() + " " + nextWord;
+                            String lineWithNextWord = nextLineToDraw + " " + nextWord;
                             lengthIfUsingNextWord =
                                 (font.getStringWidth( lineWithNextWord )/FONTSCALE) * fontSize;
                         }