[GitHub] spark pull request #22913: [SPARK-25902][SQL] Add support for dates with mil...

[HyukjinKwon <gi...@git.apache.org>]

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22913#discussion_r230544838
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowUtils.scala ---
    @@ -71,6 +71,7 @@ object ArrowUtils {
         case d: ArrowType.Decimal => DecimalType(d.getPrecision, d.getScale)
         case date: ArrowType.Date if date.getUnit == DateUnit.DAY => DateType
         case ts: ArrowType.Timestamp if ts.getUnit == TimeUnit.MICROSECOND => TimestampType
    +    case date: ArrowType.Date if date.getUnit == DateUnit.MILLISECOND => TimestampType
    --- End diff --
    
    Wait .. is it correct to map it to `TimestampType`? Looks this is why `Date` with `MILLISECOND` is not added.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org