You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2017/01/20 07:31:56 UTC

Review Request 55749: Added CMake to standard documentation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55749/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Bugs: MESOS-3139
    https://issues.apache.org/jira/browse/MESOS-3139


Repository: mesos


Description
-------

Added CMake to standard documentation.


Diffs
-----

  docs/configuration.md 2113d06f58dddc0a28ae1241a24096266fe39801 

Diff: https://reviews.apache.org/r/55749/diff/


Testing
-------


Thanks,

Alex Clemmer

Re: Review Request 55749: Added CMake to standard documentation.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55749/#review164378
-----------------------------------------------------------


Ship it!




- Andrew Schwartzmeyer


On Jan. 29, 2017, 7:22 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55749/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2017, 7:22 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-3139
>     https://issues.apache.org/jira/browse/MESOS-3139
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake to standard documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 2113d06f58dddc0a28ae1241a24096266fe39801 
> 
> Diff: https://reviews.apache.org/r/55749/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 55749: Added CMake to standard documentation.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55749/#review165578
-----------------------------------------------------------


Ship it!




Whitespace nits that I can fix before committing.


docs/configuration-cmake.md (line 2)
<https://reviews.apache.org/r/55749/#comment237436>

    CMake Configuration



docs/configuration-cmake.md (line 9)
<https://reviews.apache.org/r/55749/#comment237434>

    We're extremely inconsistent about this in the documentation, but we try to stick to a 80 character soft limit where possible.


- Joseph Wu


On Feb. 13, 2017, 6:18 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55749/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 6:18 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-3139
>     https://issues.apache.org/jira/browse/MESOS-3139
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake to standard documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration-cmake.md PRE-CREATION 
>   docs/configuration.md 656aaa34915eaee91d388febbc7574287b9f51b5 
>   docs/home.md 091dae20b0a26aac03186edaefab93c54b3063b4 
> 
> Diff: https://reviews.apache.org/r/55749/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 55749: Added CMake to standard documentation.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55749/
-----------------------------------------------------------

(Updated Feb. 14, 2017, 2:18 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Changes
-------

Split CMake documentation out to its own file.


Bugs: MESOS-3139
    https://issues.apache.org/jira/browse/MESOS-3139


Repository: mesos


Description
-------

Added CMake to standard documentation.


Diffs (updated)
-----

  docs/configuration-cmake.md PRE-CREATION 
  docs/configuration.md 656aaa34915eaee91d388febbc7574287b9f51b5 
  docs/home.md 091dae20b0a26aac03186edaefab93c54b3063b4 

Diff: https://reviews.apache.org/r/55749/diff/


Testing
-------


Thanks,

Alex Clemmer

Re: Review Request 55749: Added CMake to standard documentation.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55749/
-----------------------------------------------------------

(Updated Jan. 29, 2017, 7:22 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Changes
-------

Rearrange dependencies.


Bugs: MESOS-3139
    https://issues.apache.org/jira/browse/MESOS-3139


Repository: mesos


Description
-------

Added CMake to standard documentation.


Diffs
-----

  docs/configuration.md 2113d06f58dddc0a28ae1241a24096266fe39801 

Diff: https://reviews.apache.org/r/55749/diff/


Testing
-------


Thanks,

Alex Clemmer

Re: Review Request 55749: Added CMake to standard documentation.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55749/#review162404
-----------------------------------------------------------



Bad patch!

Reviews applied: [55749, 55748, 55696, 55695, 55694, 55637, 55632, 55607, 55604, 55602, 55601, 55600, 55599, 55550, 55549, 55548, 55547, 55546, 55544, 55543, 55328, 55327, 55314, 55313, 55312, 55311, 55162, 55161, 55040, 55039, 55038, 55037, 55699, 55030, 55024, 55023, 55022]

Failed command: python support/apply-reviews.py -n -r 55601

Error:
2017-01-20 10:15:38 URL:https://reviews.apache.org/r/55601/diff/raw/ [23809/23809] -> "55601.patch" [1]
error: patch failed: src/CMakeLists.txt:268
error: src/CMakeLists.txt: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/16790/console

- Mesos Reviewbot


On Jan. 20, 2017, 7:31 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55749/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2017, 7:31 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-3139
>     https://issues.apache.org/jira/browse/MESOS-3139
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake to standard documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 2113d06f58dddc0a28ae1241a24096266fe39801 
> 
> Diff: https://reviews.apache.org/r/55749/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>