[jira] [Commented] (DRILL-6124) testCountDownLatch can be null in PartitionerDecorator depending on user's injection controls config

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346189#comment-16346189 ] 

ASF GitHub Bot commented on DRILL-6124:
---------------------------------------

GitHub user ilooner opened a pull request:

    https://github.com/apache/drill/pull/1103

    DRILL-6124: Fixed possible NPE when no injection site is defined for …

    …"partitioner-sender-latch" in PartitionerDecorator.
    
    ```
    injector.getLatch(context.getExecutionControls(), "partitioner-sender-latch");
    ```
    
    Can return null if the user does not have the appropriate injection defined in their config.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ilooner/drill DRILL-6124

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1103
    
----
commit fee42e0ff8d4d81c76a023c58a48d851eb8da88b
Author: Timothy Farkas <ti...@...>
Date:   2018-01-30T22:27:05Z

    DRILL-6124: Fixed possible NPE when no injection site is defined for "partitioner-sender-latch" in PartitionerDecorator.

----


> testCountDownLatch can be null in PartitionerDecorator depending on user's injection controls config
> ----------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-6124
>                 URL: https://issues.apache.org/jira/browse/DRILL-6124
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Major
>
> In PartitionerDecorator we get a latch from the injector with the following code.
> testCountDownLatch = injector.getLatch(context.getExecutionControls(), "partitioner-sender-latch");
> However, if there is no injection site defined in the user's drill configuration then testCountDownLatch will be null. So we have to check if it is null in order to avoid NPE's



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)