[GitHub] [servicecomb-java-chassis] wujimin commented on a change in pull request #1209: [SCB-1278] Not send x-cse* header to third party service by default

[GitBox <gi...@apache.org>]

wujimin commented on a change in pull request #1209: [SCB-1278] Not send x-cse* header to third party service by default
URL: https://github.com/apache/servicecomb-java-chassis/pull/1209#discussion_r285718301
 
 

 ##########
 File path: core/src/main/java/org/apache/servicecomb/core/Endpoint.java
 ##########
 @@ -61,6 +61,13 @@ public Object getAddress() {
     return address;
   }
 
+  public boolean isThirdPartyEndpoint() {
+    if (null == this.instance) {
 
 Review comment:
   seems not so good.
   we also need to support register 3rd services to SC, sometimes maybe also not allow send context header to that target.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services