You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/07/04 08:30:00 UTC
[GitHub] [echarts] tyn1998 opened a new issue, #17309: [Bug] incorrect dataGroupId for old data items in universalTransition
tyn1998 opened a new issue, #17309:
URL: https://github.com/apache/echarts/issues/17309
### Version
5.3.0
### Link to Minimal Reproduction
https://codepen.io/tyn1998/pen/GRxpgQq
### Steps to Reproduce
1. visit my codepen url above
2. click "Animals" bar (works)
3. click "Back" (not works)
4. comment line 12 `dataGroupId: "",` and repeat 2 and 3 they both will work
### Current Behavior
Hi, Echarts core team!
I have read the related source code so I know where the problem occurs.
https://github.com/apache/echarts/blob/89d57f21b7eabfcc6770447f6cf6a20a8f406585/src/animation/universalTransition.ts#L210
When processing old data items, after executing this line, dataGroupId is wrongly assigned a value that is belong to new data items, which is due to the factor of having `notMerge` set to false when `.setOption(newOption)`.
This bug will not be exposed when data item's `groupId` is specified.
### Expected Behavior
Old data items should be given correct dataGroupId when item.groupId is not specified.
### Environment
```markdown
- OS: macOS Monterey
- Browser: Chrome 103
- Framework: None
```
### Any additional comments?
N.A.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] tyn1998 commented on issue #17309: [Bug] incorrect dataGroupId for old data items in universalTransition
Posted by GitBox <gi...@apache.org>.
tyn1998 commented on issue #17309:
URL: https://github.com/apache/echarts/issues/17309#issuecomment-1235081073
Complement:
if Echarts cannot find `dataGroupId` in `series`, it will try to find it in parent model:
https://github.com/apache/echarts/blob/7f3b2ba4d2f4f77c70b51a8e1bb0b227ca197df0/src/model/Model.ts#L234-L239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] tyn1998 commented on issue #17309: [Bug] incorrect dataGroupId for old data items in universalTransition
Posted by GitBox <gi...@apache.org>.
tyn1998 commented on issue #17309:
URL: https://github.com/apache/echarts/issues/17309#issuecomment-1280157703
closed via #17559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] tyn1998 closed issue #17309: [Bug] incorrect dataGroupId for old data items in universalTransition
Posted by GitBox <gi...@apache.org>.
tyn1998 closed issue #17309: [Bug] incorrect dataGroupId for old data items in universalTransition
URL: https://github.com/apache/echarts/issues/17309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] tyn1998 commented on issue #17309: [Bug] incorrect dataGroupId for old data items in universalTransition
Posted by GitBox <gi...@apache.org>.
tyn1998 commented on issue #17309:
URL: https://github.com/apache/echarts/issues/17309#issuecomment-1233638026
> which is due to the factor of having `notMerge` set to false when `.setOption(newOption)`.
Can be supported by another case in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org