You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by gi...@git.apache.org on 2017/06/22 11:40:07 UTC

[GitHub] utzig commented on issue #343: Enable i2c_scan only when there is I2C peripheral

utzig commented on issue #343: Enable i2c_scan only when there is I2C peripheral
URL: https://github.com/apache/incubator-mynewt-core/pull/343#issuecomment-310355352
 
 
   If `i2c_scan` was actually used by other apps apart from slinky, maybe it would have been better to protect its code with something like:
   ```
   #if MYNEWT_VAL(I2C_0) || MYNEWT_VAL(I2C_1) || MYNEWT_VAL(I2C_2)
   // i2c_scan's code...
   #endif
   ```
   But doesn't seem necessary for now.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services