[GitHub] [airflow] andrewgodwin commented on a change in pull request #15207: Fixed #14270: Add error message in OOM situations

[GitBox <gi...@apache.org>]

andrewgodwin commented on a change in pull request #15207:
URL: https://github.com/apache/airflow/pull/15207#discussion_r607220353



##########
File path: tests/task/task_runner/test_standard_task_runner.py
##########
@@ -48,22 +48,24 @@
             'class': 'logging.StreamHandler',
             'formatter': 'airflow.task',
             'stream': 'ext://sys.stdout',
-        }
+        },
     },
-    'loggers': {'airflow': {'handlers': ['console'], 'level': 'INFO', 'propagate': False}},
+    'loggers': {'airflow': {'handlers': ['console'], 'level': 'INFO', 'propagate': True}},
 }
 
 
-class TestStandardTaskRunner(unittest.TestCase):
-    @classmethod
-    def setUpClass(cls):
+class TestStandardTaskRunner:
+    @pytest.fixture(autouse=True, scope="class")
+    def logging_and_db(self):
+        """
+        This fixture sets up logging to have a different setup on the way in
+        (as the test environment does not have enough context for the normal
+        way to run) and ensures they reset back to normal on the way out.
+        """
         dictConfig(LOGGING_CONFIG)
-
-    @classmethod
-    def tearDownClass(cls):
+        yield

Review comment:
       When you write pytest fixtures, `yield` signifies where the test should run. In this case, it is sitting in between the old setUp and tearDown portions to signify the test should run there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org