You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/11/05 04:15:05 UTC
[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request
#84: Fixed locking between connection_reader and connection
cckellogg commented on a change in pull request #84: Fixed locking between connection_reader and connection
URL: https://github.com/apache/pulsar-client-go/pull/84#discussion_r342376146
##########
File path: pulsar/internal/connection.go
##########
@@ -129,9 +134,9 @@ type connection struct {
requestIDGenerator uint64
incomingRequestsCh chan *request
+ incomingCmdCh chan *incomingCmd
writeRequestsCh chan []byte
- mapMutex sync.RWMutex
pendingReqs map[uint64]*request
Review comment:
Maybe add a comment on how this should only be accessed in certain places?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services