You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/01/22 02:53:40 UTC

[GitHub] [incubator-pinot] codecov-io commented on issue #5002: Handle sun.nio.ch.DirectBuffer cleaner behavior for jdk 8+

codecov-io commented on issue #5002: Handle sun.nio.ch.DirectBuffer cleaner behavior for jdk 8+
URL: https://github.com/apache/incubator-pinot/pull/5002#issuecomment-576984228
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5002?src=pr&el=h1) Report
   > Merging [#5002](https://codecov.io/gh/apache/incubator-pinot/pull/5002?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/49a56faa78daf4dd32e09d375d4bb11400719782?src=pr&el=desc) will **increase** coverage by `0.02%`.
   > The diff coverage is `56.92%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5002/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/5002?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5002      +/-   ##
   ============================================
   + Coverage      57.3%   57.33%   +0.02%     
     Complexity       12       12              
   ============================================
     Files          1178     1179       +1     
     Lines         62619    62682      +63     
     Branches       9201     9204       +3     
   ============================================
   + Hits          35885    35939      +54     
   + Misses        24063    24052      -11     
   - Partials       2671     2691      +20
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5002?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...che/pinot/core/segment/memory/PinotByteBuffer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5002/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L21lbW9yeS9QaW5vdEJ5dGVCdWZmZXIuamF2YQ==) | `79.16% <50%> (-1.12%)` | `0 <0> (ø)` | |
   | [...n/java/org/apache/pinot/core/util/CleanerUtil.java](https://codecov.io/gh/apache/incubator-pinot/pull/5002/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL0NsZWFuZXJVdGlsLmphdmE=) | `57.37% <57.37%> (ø)` | `0 <0> (?)` | |
   | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5002/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | |
   | [.../realtime/impl/ThreadSafeMutableRoaringBitmap.java](https://codecov.io/gh/apache/incubator-pinot/pull/5002/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL1RocmVhZFNhZmVNdXRhYmxlUm9hcmluZ0JpdG1hcC5qYXZh) | `92.85% <0%> (-7.15%)` | `0% <0%> (ø)` | |
   | [.../pinot/core/operator/docidsets/BitmapDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/5002/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvQml0bWFwRG9jSWRTZXQuamF2YQ==) | `78.12% <0%> (-6.25%)` | `0% <0%> (ø)` | |
   | [...lix/core/realtime/PinotRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5002/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90UmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh) | `74.87% <0%> (-5.65%)` | `0% <0%> (ø)` | |
   | [.../broker/routing/HelixExternalViewBasedRouting.java](https://codecov.io/gh/apache/incubator-pinot/pull/5002/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUm91dGluZy5qYXZh) | `86.19% <0%> (-3.69%)` | `0% <0%> (ø)` | |
   | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5002/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `62.19% <0%> (-2.44%)` | `0% <0%> (ø)` | |
   | [...not/broker/broker/helix/ClusterChangeMediator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5002/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0NsdXN0ZXJDaGFuZ2VNZWRpYXRvci5qYXZh) | `74.72% <0%> (-2.2%)` | `0% <0%> (ø)` | |
   | [...l/FixedByteSingleColumnMultiValueReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5002/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXJ3cml0ZXIvaW1wbC9GaXhlZEJ5dGVTaW5nbGVDb2x1bW5NdWx0aVZhbHVlUmVhZGVyV3JpdGVyLmphdmE=) | `68.91% <0%> (-2.08%)` | `0% <0%> (ø)` | |
   | ... and [19 more](https://codecov.io/gh/apache/incubator-pinot/pull/5002/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5002?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5002?src=pr&el=footer). Last update [49a56fa...1e6dd26](https://codecov.io/gh/apache/incubator-pinot/pull/5002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org