You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@druid.apache.org by Francesco Nidito <fr...@viralize.com> on 2020/01/07 08:05:32 UTC
Review request (autoscaling for GCE)
Happy new year!
At the beginning of December we opened a PR to add support for autoscaling
for GCE but it has not been given any attention so far.
This is a change that we made internally at Viralize for our own use and it
has been running for a while now. We contributed it back into the project
as we believe it may be useful to a wider audience of users on GCE.
The PR can be found at the following link →
https://github.com/apache/druid/pull/8987
Thanks in advance for any feedback you could provide to us :)
Happy new year again!
Francesco
--
Francesco Nidito
*Lead Software Development Engineer*
+39 339 2446640
Skype: francesco.nidito
francesco.nidito@viralize.com <%7Bthis.state.email%7D>Viralize
Milan | London | Madrid | Rome | Florence (HQ)viralize.com
<http://www.viralize.com/>
Re: Review request (autoscaling for GCE)
Posted by Francesco Nidito <fr...@viralize.com>.
Hi Clint — as 0.17 has been released, let me know if you need some input
from me on the PR for the autoscaling for GCE.
Francesco
On Fri, Jan 17, 2020 at 8:39 PM Clint Wylie <cw...@apache.org> wrote:
> Apologies for the delay, I haven't had much extra time to review PRs lately
> because I've been focusing on testing and fixing up bugs for 0.17 release,
> but I will try to have a look at this PR sometime in the next couple of
> weeks because once upon a time I also implemented an autoscaler for google
> cloud, though it was more like the aws autoscaler and didn't use managed
> instance groups.
>
> On Fri, Jan 17, 2020 at 4:15 AM Roman Leventov <le...@gmail.com>
> wrote:
>
> > Committers not having enough motivation to review doesn't necessarily
> mean
> > there is a lack of interest. You may try to review someone else's sizable
> > PR and kindly ask them to reciprocate by reviewing your PR. This strategy
> > worked for me in the past.
> >
> > On Fri, 17 Jan 2020 at 11:15, Francesco Nidito <
> > francesco.nidito@viralize.com> wrote:
> >
> > > Hello again!
> > >
> > > Is there any interest from the community on this change?
> > >
> > > Cheers,
> > > Francesco
> > >
> > > On Tue, Jan 7, 2020 at 9:05 AM Francesco Nidito <
> > > francesco.nidito@viralize.com> wrote:
> > >
> > > > Happy new year!
> > > >
> > > > At the beginning of December we opened a PR to add support for
> > > autoscaling
> > > > for GCE but it has not been given any attention so far.
> > > >
> > > > This is a change that we made internally at Viralize for our own use
> > and
> > > > it has been running for a while now. We contributed it back into the
> > > > project as we believe it may be useful to a wider audience of users
> on
> > > GCE.
> > > >
> > > > The PR can be found at the following link →
> > > > https://github.com/apache/druid/pull/8987
> > > >
> > > > Thanks in advance for any feedback you could provide to us :)
> > > >
> > > > Happy new year again!
> > > >
> > > > Francesco
> > > >
> > > > --
> > > > Francesco Nidito
> > > > *Lead Software Development Engineer*
> > > > +39 339 2446640
> > > > Skype: francesco.nidito
> > > > francesco.nidito@viralize.com <%7Bthis.state.email%7D>Viralize
> > > > Milan | London | Madrid | Rome | Florence (HQ)viralize.com
> > > > <http://www.viralize.com/>
> > > >
> > >
> > >
> > > --
> > > Francesco Nidito
> > > *Lead Software Development Engineer*
> > > +39 339 2446640
> > > Skype: francesco.nidito
> > > francesco.nidito@viralize.com <%7Bthis.state.email%7D>Viralize
> > > Milan | London | Madrid | Rome | Florence (HQ)viralize.com
> > > <http://www.viralize.com/>
> > >
> >
>
--
Francesco Nidito
*Lead Software Development Engineer*
+39 339 2446640
Skype: francesco.nidito
francesco.nidito@viralize.com <%7Bthis.state.email%7D>Viralize
Milan | London | Madrid | Rome | Florence (HQ)viralize.com
<http://www.viralize.com/>
Re: Review request (autoscaling for GCE)
Posted by Clint Wylie <cw...@apache.org>.
Apologies for the delay, I haven't had much extra time to review PRs lately
because I've been focusing on testing and fixing up bugs for 0.17 release,
but I will try to have a look at this PR sometime in the next couple of
weeks because once upon a time I also implemented an autoscaler for google
cloud, though it was more like the aws autoscaler and didn't use managed
instance groups.
On Fri, Jan 17, 2020 at 4:15 AM Roman Leventov <le...@gmail.com>
wrote:
> Committers not having enough motivation to review doesn't necessarily mean
> there is a lack of interest. You may try to review someone else's sizable
> PR and kindly ask them to reciprocate by reviewing your PR. This strategy
> worked for me in the past.
>
> On Fri, 17 Jan 2020 at 11:15, Francesco Nidito <
> francesco.nidito@viralize.com> wrote:
>
> > Hello again!
> >
> > Is there any interest from the community on this change?
> >
> > Cheers,
> > Francesco
> >
> > On Tue, Jan 7, 2020 at 9:05 AM Francesco Nidito <
> > francesco.nidito@viralize.com> wrote:
> >
> > > Happy new year!
> > >
> > > At the beginning of December we opened a PR to add support for
> > autoscaling
> > > for GCE but it has not been given any attention so far.
> > >
> > > This is a change that we made internally at Viralize for our own use
> and
> > > it has been running for a while now. We contributed it back into the
> > > project as we believe it may be useful to a wider audience of users on
> > GCE.
> > >
> > > The PR can be found at the following link →
> > > https://github.com/apache/druid/pull/8987
> > >
> > > Thanks in advance for any feedback you could provide to us :)
> > >
> > > Happy new year again!
> > >
> > > Francesco
> > >
> > > --
> > > Francesco Nidito
> > > *Lead Software Development Engineer*
> > > +39 339 2446640
> > > Skype: francesco.nidito
> > > francesco.nidito@viralize.com <%7Bthis.state.email%7D>Viralize
> > > Milan | London | Madrid | Rome | Florence (HQ)viralize.com
> > > <http://www.viralize.com/>
> > >
> >
> >
> > --
> > Francesco Nidito
> > *Lead Software Development Engineer*
> > +39 339 2446640
> > Skype: francesco.nidito
> > francesco.nidito@viralize.com <%7Bthis.state.email%7D>Viralize
> > Milan | London | Madrid | Rome | Florence (HQ)viralize.com
> > <http://www.viralize.com/>
> >
>
Re: Review request (autoscaling for GCE)
Posted by Roman Leventov <le...@gmail.com>.
Committers not having enough motivation to review doesn't necessarily mean
there is a lack of interest. You may try to review someone else's sizable
PR and kindly ask them to reciprocate by reviewing your PR. This strategy
worked for me in the past.
On Fri, 17 Jan 2020 at 11:15, Francesco Nidito <
francesco.nidito@viralize.com> wrote:
> Hello again!
>
> Is there any interest from the community on this change?
>
> Cheers,
> Francesco
>
> On Tue, Jan 7, 2020 at 9:05 AM Francesco Nidito <
> francesco.nidito@viralize.com> wrote:
>
> > Happy new year!
> >
> > At the beginning of December we opened a PR to add support for
> autoscaling
> > for GCE but it has not been given any attention so far.
> >
> > This is a change that we made internally at Viralize for our own use and
> > it has been running for a while now. We contributed it back into the
> > project as we believe it may be useful to a wider audience of users on
> GCE.
> >
> > The PR can be found at the following link →
> > https://github.com/apache/druid/pull/8987
> >
> > Thanks in advance for any feedback you could provide to us :)
> >
> > Happy new year again!
> >
> > Francesco
> >
> > --
> > Francesco Nidito
> > *Lead Software Development Engineer*
> > +39 339 2446640
> > Skype: francesco.nidito
> > francesco.nidito@viralize.com <%7Bthis.state.email%7D>Viralize
> > Milan | London | Madrid | Rome | Florence (HQ)viralize.com
> > <http://www.viralize.com/>
> >
>
>
> --
> Francesco Nidito
> *Lead Software Development Engineer*
> +39 339 2446640
> Skype: francesco.nidito
> francesco.nidito@viralize.com <%7Bthis.state.email%7D>Viralize
> Milan | London | Madrid | Rome | Florence (HQ)viralize.com
> <http://www.viralize.com/>
>
Re: Review request (autoscaling for GCE)
Posted by Francesco Nidito <fr...@viralize.com>.
Hello again!
Is there any interest from the community on this change?
Cheers,
Francesco
On Tue, Jan 7, 2020 at 9:05 AM Francesco Nidito <
francesco.nidito@viralize.com> wrote:
> Happy new year!
>
> At the beginning of December we opened a PR to add support for autoscaling
> for GCE but it has not been given any attention so far.
>
> This is a change that we made internally at Viralize for our own use and
> it has been running for a while now. We contributed it back into the
> project as we believe it may be useful to a wider audience of users on GCE.
>
> The PR can be found at the following link →
> https://github.com/apache/druid/pull/8987
>
> Thanks in advance for any feedback you could provide to us :)
>
> Happy new year again!
>
> Francesco
>
> --
> Francesco Nidito
> *Lead Software Development Engineer*
> +39 339 2446640
> Skype: francesco.nidito
> francesco.nidito@viralize.com <%7Bthis.state.email%7D>Viralize
> Milan | London | Madrid | Rome | Florence (HQ)viralize.com
> <http://www.viralize.com/>
>
--
Francesco Nidito
*Lead Software Development Engineer*
+39 339 2446640
Skype: francesco.nidito
francesco.nidito@viralize.com <%7Bthis.state.email%7D>Viralize
Milan | London | Madrid | Rome | Florence (HQ)viralize.com
<http://www.viralize.com/>