You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steven Willis (JIRA)" <ji...@apache.org> on 2012/07/26 00:31:34 UTC
[jira] [Created] (HADOOP-8623) hadoop jar command should respect
HADOOP_OPTS
Steven Willis created HADOOP-8623:
-------------------------------------
Summary: hadoop jar command should respect HADOOP_OPTS
Key: HADOOP-8623
URL: https://issues.apache.org/jira/browse/HADOOP-8623
Project: Hadoop Common
Issue Type: Bug
Components: scripts
Affects Versions: 2.0.0-alpha, 0.23.1
Reporter: Steven Willis
The jar command to the hadoop script should use any set HADOOP_OPTS and HADOOP_CLIENT_OPTS environment variables like all the other commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HADOOP-8623) hadoop jar command should respect
HADOOP_OPTS
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed HADOOP-8623.
---------------------------------
> hadoop jar command should respect HADOOP_OPTS
> ---------------------------------------------
>
> Key: HADOOP-8623
> URL: https://issues.apache.org/jira/browse/HADOOP-8623
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 0.23.1, 2.0.0-alpha
> Reporter: Steven Willis
> Assignee: Steven Willis
> Priority: Minor
> Fix For: 3.0.0, 2.0.2-alpha, 0.23.4
>
> Attachments: HADOOP-8623.patch
>
>
> The jar command to the hadoop script should use any set HADOOP_OPTS and HADOOP_CLIENT_OPTS environment variables like all the other commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8623) hadoop jar command should respect
HADOOP_OPTS
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8623:
------------------------------------
Priority: Minor (was: Major)
Fix Version/s: 2.1.0-alpha
Assignee: Steven Willis
Issue Type: Improvement (was: Bug)
> hadoop jar command should respect HADOOP_OPTS
> ---------------------------------------------
>
> Key: HADOOP-8623
> URL: https://issues.apache.org/jira/browse/HADOOP-8623
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 0.23.1, 2.0.0-alpha
> Reporter: Steven Willis
> Assignee: Steven Willis
> Priority: Minor
> Fix For: 2.1.0-alpha, 3.0.0
>
> Attachments: HADOOP-8623.patch
>
>
> The jar command to the hadoop script should use any set HADOOP_OPTS and HADOOP_CLIENT_OPTS environment variables like all the other commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8623) hadoop jar command should respect
HADOOP_OPTS
Posted by "Arpit Gupta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422755#comment-13422755 ]
Arpit Gupta commented on HADOOP-8623:
-------------------------------------
the same is being repeated in hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs and hadoop-mapreduce-project/bin/mapred scripts. I think we can move assignment of HADOOP_OPTS to before the case statement and remove the line from various if statements in bin/mapred and bin/hdfs.
> hadoop jar command should respect HADOOP_OPTS
> ---------------------------------------------
>
> Key: HADOOP-8623
> URL: https://issues.apache.org/jira/browse/HADOOP-8623
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.1, 2.0.0-alpha
> Reporter: Steven Willis
> Attachments: HADOOP-8623.patch
>
>
> The jar command to the hadoop script should use any set HADOOP_OPTS and HADOOP_CLIENT_OPTS environment variables like all the other commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8623) hadoop jar command should respect
HADOOP_OPTS
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422747#comment-13422747 ]
Hadoop QA commented on HADOOP-8623:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12537914/HADOOP-8623.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1220//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1220//console
This message is automatically generated.
> hadoop jar command should respect HADOOP_OPTS
> ---------------------------------------------
>
> Key: HADOOP-8623
> URL: https://issues.apache.org/jira/browse/HADOOP-8623
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.1, 2.0.0-alpha
> Reporter: Steven Willis
> Attachments: HADOOP-8623.patch
>
>
> The jar command to the hadoop script should use any set HADOOP_OPTS and HADOOP_CLIENT_OPTS environment variables like all the other commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8623) hadoop jar command should respect
HADOOP_OPTS
Posted by "Jason Lowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Lowe updated HADOOP-8623:
-------------------------------
Fix Version/s: 0.23.4
I merged this to branch-0.23 as well.
> hadoop jar command should respect HADOOP_OPTS
> ---------------------------------------------
>
> Key: HADOOP-8623
> URL: https://issues.apache.org/jira/browse/HADOOP-8623
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 0.23.1, 2.0.0-alpha
> Reporter: Steven Willis
> Assignee: Steven Willis
> Priority: Minor
> Fix For: 3.0.0, 2.0.2-alpha, 0.23.4
>
> Attachments: HADOOP-8623.patch
>
>
> The jar command to the hadoop script should use any set HADOOP_OPTS and HADOOP_CLIENT_OPTS environment variables like all the other commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8623) hadoop jar command should respect
HADOOP_OPTS
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465575#comment-13465575 ]
Hudson commented on HADOOP-8623:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #388 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/388/])
svn merge -c 1366126 FIXES: HADOOP-8623. hadoop jar command should respect HADOOP_OPTS. Contributed by Steven Willis. (Revision 1391276)
Result = UNSTABLE
jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391276
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/bin/hadoop
> hadoop jar command should respect HADOOP_OPTS
> ---------------------------------------------
>
> Key: HADOOP-8623
> URL: https://issues.apache.org/jira/browse/HADOOP-8623
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 0.23.1, 2.0.0-alpha
> Reporter: Steven Willis
> Assignee: Steven Willis
> Priority: Minor
> Fix For: 3.0.0, 2.0.2-alpha, 0.23.4
>
> Attachments: HADOOP-8623.patch
>
>
> The jar command to the hadoop script should use any set HADOOP_OPTS and HADOOP_CLIENT_OPTS environment variables like all the other commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8623) hadoop jar command should respect
HADOOP_OPTS
Posted by "Steven Willis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Willis updated HADOOP-8623:
----------------------------------
Status: Patch Available (was: Open)
> hadoop jar command should respect HADOOP_OPTS
> ---------------------------------------------
>
> Key: HADOOP-8623
> URL: https://issues.apache.org/jira/browse/HADOOP-8623
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 2.0.0-alpha, 0.23.1
> Reporter: Steven Willis
> Attachments: HADOOP-8623.patch
>
>
> The jar command to the hadoop script should use any set HADOOP_OPTS and HADOOP_CLIENT_OPTS environment variables like all the other commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8623) hadoop jar command should respect
HADOOP_OPTS
Posted by "Steven Willis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Willis updated HADOOP-8623:
----------------------------------
Attachment: HADOOP-8623.patch
Since every case in the big if block have would now had:
{code}HADOOP_OPTS="$HADOOP_OPTS $HADOOP_CLIENT_OPTS"{code}
I just removed each individual line and added a single line below the block. It has the nice side affect of making that big block more readable
> hadoop jar command should respect HADOOP_OPTS
> ---------------------------------------------
>
> Key: HADOOP-8623
> URL: https://issues.apache.org/jira/browse/HADOOP-8623
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.1, 2.0.0-alpha
> Reporter: Steven Willis
> Attachments: HADOOP-8623.patch
>
>
> The jar command to the hadoop script should use any set HADOOP_OPTS and HADOOP_CLIENT_OPTS environment variables like all the other commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8623) hadoop jar command should respect
HADOOP_OPTS
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423074#comment-13423074 ]
Daryn Sharp commented on HADOOP-8623:
-------------------------------------
+1 ditto
> hadoop jar command should respect HADOOP_OPTS
> ---------------------------------------------
>
> Key: HADOOP-8623
> URL: https://issues.apache.org/jira/browse/HADOOP-8623
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.1, 2.0.0-alpha
> Reporter: Steven Willis
> Attachments: HADOOP-8623.patch
>
>
> The jar command to the hadoop script should use any set HADOOP_OPTS and HADOOP_CLIENT_OPTS environment variables like all the other commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8623) hadoop jar command should respect
HADOOP_OPTS
Posted by "Steven Willis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474367#comment-13474367 ]
Steven Willis commented on HADOOP-8623:
---------------------------------------
I am out of the office until Tuesday October 16th. Please contact Seth Madison for any urgent issues.
> hadoop jar command should respect HADOOP_OPTS
> ---------------------------------------------
>
> Key: HADOOP-8623
> URL: https://issues.apache.org/jira/browse/HADOOP-8623
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 0.23.1, 2.0.0-alpha
> Reporter: Steven Willis
> Assignee: Steven Willis
> Priority: Minor
> Fix For: 3.0.0, 2.0.2-alpha, 0.23.4
>
> Attachments: HADOOP-8623.patch
>
>
> The jar command to the hadoop script should use any set HADOOP_OPTS and HADOOP_CLIENT_OPTS environment variables like all the other commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8623) hadoop jar command should respect
HADOOP_OPTS
Posted by "Arpit Gupta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422827#comment-13422827 ]
Arpit Gupta commented on HADOOP-8623:
-------------------------------------
Actually thinking about it more, hdfs and mapred could have separate configs and can be invoked independently from the bin/hadoop script so the current changes look good to go.
+1
> hadoop jar command should respect HADOOP_OPTS
> ---------------------------------------------
>
> Key: HADOOP-8623
> URL: https://issues.apache.org/jira/browse/HADOOP-8623
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.1, 2.0.0-alpha
> Reporter: Steven Willis
> Attachments: HADOOP-8623.patch
>
>
> The jar command to the hadoop script should use any set HADOOP_OPTS and HADOOP_CLIENT_OPTS environment variables like all the other commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8623) hadoop jar command should respect
HADOOP_OPTS
Posted by "Steven Willis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422698#comment-13422698 ]
Steven Willis commented on HADOOP-8623:
---------------------------------------
Like HADOOP-7491 which added these environment variables to the case where the hadoop script is run with a classname, they should also be used when run with jar as the command. All the other commands use these env vars, I can't see why jar doesn't.
> hadoop jar command should respect HADOOP_OPTS
> ---------------------------------------------
>
> Key: HADOOP-8623
> URL: https://issues.apache.org/jira/browse/HADOOP-8623
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.1, 2.0.0-alpha
> Reporter: Steven Willis
>
> The jar command to the hadoop script should use any set HADOOP_OPTS and HADOOP_CLIENT_OPTS environment variables like all the other commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8623) hadoop jar command should respect
HADOOP_OPTS
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8623:
------------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Thanks for contributing the patch Steven. I have added you as a contributor to Hadoop common. You can now assign the jiras to yourself.
I committed the patch to trunk. Will merge it into 2.x next.
> hadoop jar command should respect HADOOP_OPTS
> ---------------------------------------------
>
> Key: HADOOP-8623
> URL: https://issues.apache.org/jira/browse/HADOOP-8623
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.1, 2.0.0-alpha
> Reporter: Steven Willis
> Fix For: 3.0.0
>
> Attachments: HADOOP-8623.patch
>
>
> The jar command to the hadoop script should use any set HADOOP_OPTS and HADOOP_CLIENT_OPTS environment variables like all the other commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira