You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/04/24 11:42:40 UTC

[jira] [Commented] (PHOENIX-628) Support native JSON data type

    [ https://issues.apache.org/jira/browse/PHOENIX-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510731#comment-14510731 ] 

ASF GitHub Bot commented on PHOENIX-628:
----------------------------------------

GitHub user AakashPradeep opened a pull request:

    https://github.com/apache/phoenix/pull/76

    PHOENIX-628 Support native JSON data type

    This pull request has following changes:
    
    1. Renames
         a)  PJsonDataType to PJson
         b)  PJsonDataTypeTest to PJsonTest 
         c) PhoenixJsonE2ETest to PhoenixJsonIT
    
    2. Added new SqlException Code INVALID_JSON_DATA
    3. Some changes in PhoenixJson
    4. Removed overridden method from PJson for which default implementation is fine.
            a) coerceBytes()
            b) isCoercibleTo().
    
    
    @JamesRTaylor and @twdsilva  please review the changelist.  
    
    Note : Some of the classes have space formatting problem, I am trying to fix my eclipse for that. Hopefully it will be resolved in next pull request. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AakashPradeep/phoenix json

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #76
    
----
commit bab8f40c745b0f3cfd28597d6938574f4ba91ea2
Author: Aakash <aa...@salesforce.com>
Date:   2015-04-14T01:32:10Z

    Support native JSON data type and json_extract_path function PHOENIX-1743 and PHOENIX-1710

commit a18f617398e32dd9f5599316a408f401302f3182
Author: Aakash <aa...@salesforce.com>
Date:   2015-04-24T09:31:55Z

    PHOENIX-628 Support native JSON data type - fix for first review

----


> Support native JSON data type
> -----------------------------
>
>                 Key: PHOENIX-628
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-628
>             Project: Phoenix
>          Issue Type: Task
>    Affects Versions: 4.4.0
>            Reporter: James Taylor
>            Assignee: Aakash Pradeep
>              Labels: JSON, Java, SQL
>             Fix For: 4.4.0
>
>
> MongoDB and PostGres do some interesting things with JSON. We should look at adding similar support. For a detailed description, see JSONB support in Postgres: 
> http://www.craigkerstiens.com/2014/03/24/Postgres-9.4-Looking-up
> http://www.depesz.com/2014/03/25/waiting-for-9-4-introduce-jsonb-a-structured-format-for-storing-json/
> http://michael.otacoo.com/postgresql-2/manipulating-jsonb-data-with-key-unique/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)