You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by Alex-Cook4 <gi...@git.apache.org> on 2016/04/15 01:00:11 UTC
[GitHub] incubator-quarks-website pull request: Make video dynamically size...
GitHub user Alex-Cook4 opened a pull request:
https://github.com/apache/incubator-quarks-website/pull/42
Make video dynamically sized.
Video was overlapping with text in certain formats.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Alex-Cook4/incubator-quarks-website master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quarks-website/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit 5afd8909d9590b9583a1b35bfc159cb2f9e79fbc
Author: Alex-Cook4 <co...@us.ibm.com>
Date: 2016-04-14T22:21:12Z
Merge pull request #5 from apache/master
Get latest master
commit b9a778a52b479b61d986796bc2320efb66681bda
Author: Alex-Cook4 <co...@us.ibm.com>
Date: 2016-04-14T22:56:39Z
Update video to adapt to size change.
commit e3a937a665638bb96b77a703b45102ba3837956e
Author: Alex-Cook4 <co...@us.ibm.com>
Date: 2016-04-14T22:59:29Z
Changed the size slightly.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: Make video dynamically size...
Posted by Cazen <gi...@git.apache.org>.
Github user Cazen commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/42#issuecomment-210812906
Good day @Alex-Cook4
- Sorry for confusing. I thought there is not frameborder setting in your change because video's bottom line is not presented. But it's not(And 0 or 1 is right. 3 is mistake). It seems slightly truncated. Now I think frameborder is no correlation in this problem(unnecessary). Sorry again.
- I think this issue related on responsive video issue. In fact, I think there is no problem with youtube size is automatically adjusted depending on the size of the window and accurately played with no error. So how about this way like below?
```
<div class="col-lg-6 col-sm-pull-5 col-sm-6">
<div class="embed-responsive embed-responsive-16by9">
<iframe class="embed-responsive-item" src="//www.youtube.com/embed/Xqns7yVNDnk" allowfullscreen></iframe>
</div>
</div>
```
- Of course, I'm not an expert on bootstrap. Please tell me if I was wrong or there is better way to solve this problem. I'm happy to hear that. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: Make video dynamically size...
Posted by Alex-Cook4 <gi...@git.apache.org>.
Github user Alex-Cook4 commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/42#issuecomment-212948209
@Cazen that's exactly what I was looking for. Thank you!
With my latest commit, this should be ready to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: Make video dynamically size...
Posted by Cazen <gi...@git.apache.org>.
Github user Cazen commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/42#issuecomment-215273969
Hi @Alex-Cook4
I'm very sorry and didn't mean to bother you. I know you point out exactly about resizing issue and PR was great.
But Could I kindly ask that did you intend to expand youtube screen?(Size after this patch is larger than previous fixed screen size)
And other events are going to be opened soon, so I hope apply this patch in the early hours
(Could Any committers please review this patch? I do not have commit privilege yet)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: Make video dynamically size...
Posted by Alex-Cook4 <gi...@git.apache.org>.
Github user Alex-Cook4 commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/42#issuecomment-210483248
@Cazen good idea on the frameborder! I'm not familiar with frameborder, but as a html property, it only takes 0|1. I changed it to 1. That gives us:
What were you thinking with the 3?
I'm also not very happy with how I did the dynamic sizing since I had to give the outside dive a defined height:290px in order for the percentages to work. Maybe you're more familiar with iframes and know a better way?
```
<div style="height:290px;" class="col-lg-7 col-sm-pull-5 col-sm-6">
<iframe style="width:85%;height:100%" src="//www.youtube.com/embed/Xqns7yVNDnk" frameborder="1" allowfullscreen></iframe>
</div>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: Make video dynamically size...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quarks-website/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: Make video dynamically size...
Posted by Cazen <gi...@git.apache.org>.
Github user Cazen commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/42#issuecomment-210248301
LGTM
And It's just my opinion but how about give some frameborder(maybe 3)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks-website pull request: Make video dynamically size...
Posted by Alex-Cook4 <gi...@git.apache.org>.
Github user Alex-Cook4 commented on the pull request:
https://github.com/apache/incubator-quarks-website/pull/42#issuecomment-213619525
This is ready for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---