You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "liurenjie1024 (via GitHub)" <gi...@apache.org> on 2023/06/01 10:17:20 UTC

[GitHub] [arrow-datafusion] liurenjie1024 commented on issue #6405: Move tpch tests into sqllogictest.

liurenjie1024 commented on issue #6405:
URL: https://github.com/apache/arrow-datafusion/issues/6405#issuecomment-1571762953

   > @alamb @liurenjie1024
   > 
   > I do not think moving the tpch plan verification into sqllogictest is a good idea, because the plan is usually quite complex and It is very hard to compare the plan and fix the change part in the `slt` files.
   
   I think the complexity of comparing is caused by text plan representation. As with fixing the change part, you can run `--complete` mode, which will fix slt result automatically.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org